From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: [PATCH net 3/5] igb: fix race accessing page->_count Date: Thu, 9 Oct 2014 22:24:52 -0700 Message-ID: <1412918694-22882-4-git-send-email-edumazet@google.com> References: <1412918694-22882-1-git-send-email-edumazet@google.com> Cc: netdev@vger.kernel.org, Alexander Duyck , Andres Lagar-Cavilla , Greg Thelen , Hugh Dickins , David Rientjes , Eric Dumazet To: "David S. Miller" Return-path: Received: from mail-pd0-f201.google.com ([209.85.192.201]:54839 "EHLO mail-pd0-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751647AbaJJFZF (ORCPT ); Fri, 10 Oct 2014 01:25:05 -0400 Received: by mail-pd0-f201.google.com with SMTP id y10so235584pdj.0 for ; Thu, 09 Oct 2014 22:25:05 -0700 (PDT) In-Reply-To: <1412918694-22882-1-git-send-email-edumazet@google.com> Sender: netdev-owner@vger.kernel.org List-ID: This is illegal to use atomic_set(&page->_count, 2) even if we 'own' the page. Other entities in the kernel need to use get_page_unless_zero() to get a reference to the page before testing page properties, so we could loose a refcount increment. Signed-off-by: Eric Dumazet --- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c index d677b5a23b58..fec5212d4337 100644 --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c @@ -1865,12 +1865,10 @@ static bool ixgbe_add_rx_frag(struct ixgbe_ring *rx_ring, /* flip page offset to other buffer */ rx_buffer->page_offset ^= truesize; - /* - * since we are the only owner of the page and we need to - * increment it, just set the value to 2 in order to avoid - * an unecessary locked operation + /* Even if we own the page, we are not allowed to use atomic_set() + * This would break get_page_unless_zero() users. */ - atomic_set(&page->_count, 2); + atomic_inc(&page->_count); #else /* move offset up to the next cache line */ rx_buffer->page_offset += truesize; -- 2.1.0.rc2.206.gedb03e5