netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 00/12] dmaengine: remove users of device_control
@ 2014-10-11 15:39 Vinod Koul
  2014-10-11 15:40 ` [PATCH 06/12] net: ks8842: use dmaengine_terminate_all() API Vinod Koul
  2014-10-15 15:58 ` [PATCH 00/12] dmaengine: remove users of device_control Vinod Koul
  0 siblings, 2 replies; 3+ messages in thread
From: Vinod Koul @ 2014-10-11 15:39 UTC (permalink / raw)
  To: dmaengine
  Cc: Vinod Koul, Viresh Kumar, Tejun Heo, Linus Walleij, Dan Williams,
	Guennadi Liakhovetski, Mauro Carvalho Chehab, David Woodhouse,
	Brian Norris, Nicolas Ferre, Mark Brown, Greg Kroah-Hartman,
	Jiri Slaby, Felipe Balbi, Jean-Christophe Plagniol-Villard,
	Tomi Valkeinen, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
	Jingoo Han, Bartlomiej Zolnierkiewicz, Laurent Pinchart

The recent discussion [1] on the API have resulted in moving away from
device_control ioctl method to proper channel APIs.
There are still few users on the device_control which should use the wrappers
existing rather than access device_control.
This will aid us in deprecating and removing device_control, possibly after
the merge window.

These can be merged thru respective subsystem tree or dmaengine tree. Either
way please just let me know.

Feng's kbuild has tested these as well [2]

[1]: http://www.spinics.net/lists/dmaengine/msg02212.html
[2]: http://git.infradead.org/users/vkoul/slave-dma.git/shortlog/refs/heads/topic/dma_control_cleanup

Vinod Koul (12):
  pata_arasan_cf: use dmaengine_terminate_all() API
  dmaengine: coh901318: use dmaengine_terminate_all() API
  [media] V4L2: mx3_camer: use dmaengine_pause() API
  mtd: fsmc_nand: use dmaengine_terminate_all() API
  mtd: sh_flctl: use dmaengine_terminate_all() API
  net: ks8842: use dmaengine_terminate_all() API
  spi/atmel: use dmaengine_terminate_all() API
  spi/spi-dw-mid.c: use dmaengine_slave_config() API
  serial: sh-sci: use dmaengine_terminate_all() API
  usb: musb: ux500_dma: use dmaengine_xxx() APIs
  ASoC: txx9: use dmaengine_terminate_all() API
  video: mx3fb: use dmaengine_terminate_all() API

 drivers/ata/pata_arasan_cf.c                   |    5 ++---
 drivers/dma/coh901318.c                        |    2 +-
 drivers/media/platform/soc_camera/mx3_camera.c |    6 ++----
 drivers/mtd/nand/fsmc_nand.c                   |    2 +-
 drivers/mtd/nand/sh_flctl.c                    |    2 +-
 drivers/net/ethernet/micrel/ks8842.c           |    6 ++----
 drivers/spi/spi-atmel.c                        |    6 ++----
 drivers/spi/spi-dw-mid.c                       |    6 ++----
 drivers/tty/serial/sh-sci.c                    |    2 +-
 drivers/usb/musb/ux500_dma.c                   |    7 ++-----
 drivers/video/fbdev/mx3fb.c                    |    3 +--
 sound/soc/txx9/txx9aclc.c                      |    7 +++----
 12 files changed, 20 insertions(+), 34 deletions(-)


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH 06/12] net: ks8842: use dmaengine_terminate_all() API
  2014-10-11 15:39 [PATCH 00/12] dmaengine: remove users of device_control Vinod Koul
@ 2014-10-11 15:40 ` Vinod Koul
  2014-10-15 15:58 ` [PATCH 00/12] dmaengine: remove users of device_control Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2014-10-11 15:40 UTC (permalink / raw)
  To: dmaengine
  Cc: Vinod Koul, Mark Brown, Bartlomiej Zolnierkiewicz, Kyungmin Park,
	Dan Williams, netdev, linux-kernel

The drivers should use dmaengine_terminate_all() API instead of
accessing the device_control which will be deprecated soon

Signed-off-by: Vinod Koul <vinod.koul@intel.com>
---
 drivers/net/ethernet/micrel/ks8842.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/micrel/ks8842.c b/drivers/net/ethernet/micrel/ks8842.c
index 822616e..0c33b92 100644
--- a/drivers/net/ethernet/micrel/ks8842.c
+++ b/drivers/net/ethernet/micrel/ks8842.c
@@ -875,13 +875,11 @@ static void ks8842_stop_dma(struct ks8842_adapter *adapter)
 
 	tx_ctl->adesc = NULL;
 	if (tx_ctl->chan)
-		tx_ctl->chan->device->device_control(tx_ctl->chan,
-			DMA_TERMINATE_ALL, 0);
+		dmaengine_terminate_all(tx_ctl->chan);
 
 	rx_ctl->adesc = NULL;
 	if (rx_ctl->chan)
-		rx_ctl->chan->device->device_control(rx_ctl->chan,
-			DMA_TERMINATE_ALL, 0);
+		dmaengine_terminate_all(rx_ctl->chan);
 
 	if (sg_dma_address(&rx_ctl->sg))
 		dma_unmap_single(adapter->dev, sg_dma_address(&rx_ctl->sg),
-- 
1.7.0.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 00/12] dmaengine: remove users of device_control
  2014-10-11 15:39 [PATCH 00/12] dmaengine: remove users of device_control Vinod Koul
  2014-10-11 15:40 ` [PATCH 06/12] net: ks8842: use dmaengine_terminate_all() API Vinod Koul
@ 2014-10-15 15:58 ` Vinod Koul
  1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2014-10-15 15:58 UTC (permalink / raw)
  To: dmaengine
  Cc: Viresh Kumar, Tejun Heo, Linus Walleij, Dan Williams,
	Guennadi Liakhovetski, Mauro Carvalho Chehab, David Woodhouse,
	Brian Norris, Nicolas Ferre, Mark Brown, Greg Kroah-Hartman,
	Jiri Slaby, Felipe Balbi, Jean-Christophe Plagniol-Villard,
	Tomi Valkeinen, Liam Girdwood, Jaroslav Kysela, Takashi Iwai,
	Jingoo Han, Bartlomiej Zolnierkiewicz, Laurent Pinchart,
	"Rafael J. Wysocki" <ra

On Sat, Oct 11, 2014 at 09:09:33PM +0530, Vinod Koul wrote:
> The recent discussion [1] on the API have resulted in moving away from
> device_control ioctl method to proper channel APIs.
> There are still few users on the device_control which should use the wrappers
> existing rather than access device_control.
> This will aid us in deprecating and removing device_control, possibly after
> the merge window.
> 
> These can be merged thru respective subsystem tree or dmaengine tree. Either
> way please just let me know.

Applying to dmaengine-next with acks recived, dropping the ones which are
applied by respective folks

-- 
~Vinod

> 
> Feng's kbuild has tested these as well [2]
> 
> [1]: http://www.spinics.net/lists/dmaengine/msg02212.html
> [2]: http://git.infradead.org/users/vkoul/slave-dma.git/shortlog/refs/heads/topic/dma_control_cleanup
> 
> Vinod Koul (12):
>   pata_arasan_cf: use dmaengine_terminate_all() API
>   dmaengine: coh901318: use dmaengine_terminate_all() API
>   [media] V4L2: mx3_camer: use dmaengine_pause() API
>   mtd: fsmc_nand: use dmaengine_terminate_all() API
>   mtd: sh_flctl: use dmaengine_terminate_all() API
>   net: ks8842: use dmaengine_terminate_all() API
>   spi/atmel: use dmaengine_terminate_all() API
>   spi/spi-dw-mid.c: use dmaengine_slave_config() API
>   serial: sh-sci: use dmaengine_terminate_all() API
>   usb: musb: ux500_dma: use dmaengine_xxx() APIs
>   ASoC: txx9: use dmaengine_terminate_all() API
>   video: mx3fb: use dmaengine_terminate_all() API
> 
>  drivers/ata/pata_arasan_cf.c                   |    5 ++---
>  drivers/dma/coh901318.c                        |    2 +-
>  drivers/media/platform/soc_camera/mx3_camera.c |    6 ++----
>  drivers/mtd/nand/fsmc_nand.c                   |    2 +-
>  drivers/mtd/nand/sh_flctl.c                    |    2 +-
>  drivers/net/ethernet/micrel/ks8842.c           |    6 ++----
>  drivers/spi/spi-atmel.c                        |    6 ++----
>  drivers/spi/spi-dw-mid.c                       |    6 ++----
>  drivers/tty/serial/sh-sci.c                    |    2 +-
>  drivers/usb/musb/ux500_dma.c                   |    7 ++-----
>  drivers/video/fbdev/mx3fb.c                    |    3 +--
>  sound/soc/txx9/txx9aclc.c                      |    7 +++----
>  12 files changed, 20 insertions(+), 34 deletions(-)
> 
> --
> To unsubscribe from this list: send the line "unsubscribe dmaengine" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-10-15 15:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-11 15:39 [PATCH 00/12] dmaengine: remove users of device_control Vinod Koul
2014-10-11 15:40 ` [PATCH 06/12] net: ks8842: use dmaengine_terminate_all() API Vinod Koul
2014-10-15 15:58 ` [PATCH 00/12] dmaengine: remove users of device_control Vinod Koul

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).