[PATCH net 0/2] qlcnic: Bug fixes

[PATCH net 0/2] qlcnic: Bug fixes

[Rajesh Borundia]

This series fixes following issues.

* We were programming maximum number of arguments supported by
  adapter instead of required in a command.
* Destroy tx command requires three arguments instead of two.

Please apply these patches to net.

Thanks,
Rajesh

Rajesh Borundia (2):
  qlcnic: Fix programming number of arguments in a command.
  qlcnic: Fix number of arguments in destroy tx context command

 drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

[PATCH net 1/2] qlcnic: Fix programming number of arguments in a command.

[Rajesh Borundia]

o Initially we were programming maximum number of arguments.
  Instead we should program number of arguments required in
  a command.
o Maximum number of arguments for 82xx adapter is four. Fix it
  for GET_ESWITCH_STATS command.

Signed-off-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
index ffbae29..243752f 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
@@ -32,7 +32,7 @@ static const struct qlcnic_mailbox_metadata qlcnic_mbx_tbl[] = {
 	{QLCNIC_CMD_CONFIGURE_ESWITCH, 4, 1},
 	{QLCNIC_CMD_GET_MAC_STATS, 4, 1},
 	{QLCNIC_CMD_GET_ESWITCH_PORT_CONFIG, 4, 3},
-	{QLCNIC_CMD_GET_ESWITCH_STATS, 5, 1},
+	{QLCNIC_CMD_GET_ESWITCH_STATS, 4, 1},
 	{QLCNIC_CMD_CONFIG_PORT, 4, 1},
 	{QLCNIC_CMD_TEMP_SIZE, 4, 4},
 	{QLCNIC_CMD_GET_TEMP_HDR, 4, 1},
@@ -129,7 +129,7 @@ int qlcnic_82xx_issue_cmd(struct qlcnic_adapter *adapter,
 	}
 
 	QLCWR32(adapter, QLCNIC_SIGN_CRB_OFFSET, signature);
-	for (i = 1; i < QLCNIC_CDRP_MAX_ARGS; i++)
+	for (i = 1; i < cmd->req.num; i++)
 		QLCWR32(adapter, QLCNIC_CDRP_ARG(i), cmd->req.arg[i]);
 	QLCWR32(adapter, QLCNIC_CDRP_CRB_OFFSET,
 		QLCNIC_CDRP_FORM_CMD(cmd->req.arg[0]));
-- 
1.6.3.3

[PATCH net 2/2] qlcnic: Fix number of arguments in destroy tx context command

[Rajesh Borundia]

o Number of arguments taken by destroy tx command is three
  instead of two.

Signed-off-by: Rajesh Borundia <rajesh.borundia@qlogic.com>
---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
index 243752f..6e6f18f 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_ctx.c
@@ -11,7 +11,7 @@ static const struct qlcnic_mailbox_metadata qlcnic_mbx_tbl[] = {
 	{QLCNIC_CMD_CREATE_RX_CTX, 4, 1},
 	{QLCNIC_CMD_DESTROY_RX_CTX, 2, 1},
 	{QLCNIC_CMD_CREATE_TX_CTX, 4, 1},
-	{QLCNIC_CMD_DESTROY_TX_CTX, 2, 1},
+	{QLCNIC_CMD_DESTROY_TX_CTX, 3, 1},
 	{QLCNIC_CMD_INTRPT_TEST, 4, 1},
 	{QLCNIC_CMD_SET_MTU, 4, 1},
 	{QLCNIC_CMD_READ_PHY, 4, 2},
-- 
1.6.3.3

Re: [PATCH net 0/2] qlcnic: Bug fixes

[David Miller]

From: Rajesh Borundia <rajesh.borundia@qlogic.com>
Date: Tue, 14 Oct 2014 07:41:44 -0400

> This series fixes following issues.
> 
> * We were programming maximum number of arguments supported by
>   adapter instead of required in a command.
> * Destroy tx command requires three arguments instead of two.
> 
> Please apply these patches to net.

Series applied, thanks.

[PATCH net 0/2] qlcnic: Bug fixes

[Shahed Shaikh]

From: Shahed Shaikh <shahed.shaikh@qlogic.com>

Hi David,

This patch series contains following fixes -

* Fix memory leak caused because of issuing mailbox
  command which can not wait for its completion.
* Reset firmware API lock which might be in inconsistent state.

Please apply this series to net.

Thanks,
Shahed

Rajesh Borundia (1):
  qlcnic: Fix memory leak.

Sony Chacko (1):
  qlcnic: Reset firmware API lock at driver load time

 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c   |    9 +++++++++
 .../ethernet/qlogic/qlcnic/qlcnic_sriov_common.c   |    9 ++++++++-
 2 files changed, 17 insertions(+), 1 deletions(-)

Re: [PATCH net 0/2] qlcnic: Bug fixes

[David Miller]

From: Shahed Shaikh <shahed.shaikh@qlogic.com>
Date: Wed, 23 Apr 2014 09:59:54 -0400

> This patch series contains following fixes -
> 
> * Fix memory leak caused because of issuing mailbox
>   command which can not wait for its completion.
> * Reset firmware API lock which might be in inconsistent state.
> 
> Please apply this series to net.

Series applied, thanks.

[PATCH net 0/2] qlcnic: Bug fixes

[Shahed Shaikh]

From: Shahed Shaikh <shahed.shaikh@qlogic.com>

Hi David,

This patch series has couple of bug fixes related to statistics.

Please apply this series to net.

Thanks,
Shahed

Manish Chopra (1):
  qlcnic: Fix bug in TX statistics

Shahed Shaikh (1):
  qlcnic: Fix ethtool statistics length calculation

 drivers/net/ethernet/qlogic/qlcnic/qlcnic.h        |  1 +
 .../net/ethernet/qlogic/qlcnic/qlcnic_ethtool.c    | 41 ++++++++++++----------
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c   |  3 ++
 3 files changed, 26 insertions(+), 19 deletions(-)

-- 
1.8.1.4

Re: [PATCH net 0/2] qlcnic: Bug fixes

[David Miller]

From: Shahed Shaikh <shahed.shaikh@qlogic.com>
Date: Thu, 9 Jan 2014 12:41:03 -0500

> This patch series has couple of bug fixes related to statistics.
> 
> Please apply this series to net.

Series applied, thank you.

[PATCH net 0/2] qlcnic: Bug fixes

[Shahed Shaikh]

From: Shahed Shaikh <shahed.shaikh@qlogic.com>

This patch series contains following fixes-
* Performace drop because driver was forcing adapter not to check
  destination IP for LRO.
* driver was not issuing qlcnic_fw_cmd_set_drv_version() to 83xx adapter
  becasue of improper handling of QLCNIC_FW_CAPABILITY_MORE_CAPS bit.

Please apply to net.

Thanks,
Shahed

Shahed Shaikh (2):
  qlcnic: Do not force adapter to perform LRO without destination IP
    check
  qlcnic: Do not read QLCNIC_FW_CAPABILITY_MORE_CAPS bit for 83xx
    adapter

 drivers/net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c | 6 +++---
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_hw.c      | 7 ++-----
 drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c    | 6 ++++--
 3 files changed, 9 insertions(+), 10 deletions(-)

-- 
1.8.1.4

Re: [PATCH net 0/2] qlcnic: Bug fixes

[David Miller]

From: Shahed Shaikh <shahed.shaikh@qlogic.com>
Date: Fri, 25 Oct 2013 10:38:35 -0400

> From: Shahed Shaikh <shahed.shaikh@qlogic.com>
> 
> This patch series contains following fixes-
> * Performace drop because driver was forcing adapter not to check
>   destination IP for LRO.
> * driver was not issuing qlcnic_fw_cmd_set_drv_version() to 83xx adapter
>   becasue of improper handling of QLCNIC_FW_CAPABILITY_MORE_CAPS bit.
> 
> Please apply to net.

Applied, what exactly does that destination IP check do?

RE: [PATCH net 0/2] qlcnic: Bug fixes

[Shahed Shaikh]

> -----Original Message-----
> From: David Miller [mailto:davem@davemloft.net]
> Sent: Saturday, October 26, 2013 9:36 AM
> To: Shahed Shaikh
> Cc: netdev; Dept-NX Linux NIC Driver
> Subject: Re: [PATCH net 0/2] qlcnic: Bug fixes
> 
> From: Shahed Shaikh <shahed.shaikh@qlogic.com>
> Date: Fri, 25 Oct 2013 10:38:35 -0400
> 
> > From: Shahed Shaikh <shahed.shaikh@qlogic.com>
> >
> > This patch series contains following fixes-
> > * Performace drop because driver was forcing adapter not to check
> >   destination IP for LRO.
> > * driver was not issuing qlcnic_fw_cmd_set_drv_version() to 83xx adapter
> >   becasue of improper handling of QLCNIC_FW_CAPABILITY_MORE_CAPS
> bit.
> >
> > Please apply to net.
> 
> Applied, what exactly does that destination IP check do?

When a destination IP is programmed, adapter will perform LRO only on TCP packets destined to the programmed IP address. 
When the adapter is programmed to skip destination IP check, adapter performs LRO on TCP packets destined to all IP addresses.

Thanks,
Shahed