From: Anish Bhatt <anish@chelsio.com>
To: netdev@vger.kernel.org, linux-scsi@vger.kernel.org
Cc: davem@davemloft.net, hch@infradead.org, jbottomley@parallels.com,
kxie@chelsio.com, manojmalviya@chelsio.com,
hariprasad@chelsio.com, leedom@chelsio.com,
swise@opengridcomputing.com, Anish Bhatt <anish@chelsio.com>
Subject: [PATCH net v2 4/4] cxgb4i: Remove duplicate call to dst_neigh_lookup()
Date: Tue, 14 Oct 2014 20:07:24 -0700 [thread overview]
Message-ID: <1413342444-16388-5-git-send-email-anish@chelsio.com> (raw)
In-Reply-To: <1413342444-16388-1-git-send-email-anish@chelsio.com>
There is an extra call to dst_neigh_lookup() leftover in cxgb4i that can cause
an unreleased refcnt issue. Remove extraneous call.
Signed-off-by: Anish Bhatt <anish@chelsio.com>
Fixes : 759a0cc5a3e1b ('cxgb4i: Add ipv6 code to driver, call into libcxgbi ipv6 api')
---
drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
index df176f0..8c3003b 100644
--- a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
+++ b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c
@@ -1317,11 +1317,6 @@ static int init_act_open(struct cxgbi_sock *csk)
cxgbi_sock_set_flag(csk, CTPF_HAS_ATID);
cxgbi_sock_get(csk);
- n = dst_neigh_lookup(csk->dst, &csk->daddr.sin_addr.s_addr);
- if (!n) {
- pr_err("%s, can't get neighbour of csk->dst.\n", ndev->name);
- goto rel_resource;
- }
csk->l2t = cxgb4_l2t_get(lldi->l2t, n, ndev, 0);
if (!csk->l2t) {
pr_err("%s, cannot alloc l2t.\n", ndev->name);
--
2.1.2
next prev parent reply other threads:[~2014-10-15 3:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 3:07 [PATCH net v2 0/4] ipv6 and related cleanup for cxgb4/cxgb4i Anish Bhatt
2014-10-15 3:07 ` [PATCH net v2 1/4] cxgb4i : Remove duplicated CLIP handling code Anish Bhatt
2014-10-15 3:07 ` [PATCH net v2 2/4] cxgb4 : Fix build failure in cxgb4 when ipv6 is disabled/not in-built Anish Bhatt
2014-10-15 3:07 ` [PATCH net v2 3/4] cxgb4i : Fix -Wunused-function warning Anish Bhatt
2014-10-15 3:07 ` Anish Bhatt [this message]
2014-10-15 4:30 ` [PATCH net v2 0/4] ipv6 and related cleanup for cxgb4/cxgb4i David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1413342444-16388-5-git-send-email-anish@chelsio.com \
--to=anish@chelsio.com \
--cc=davem@davemloft.net \
--cc=hariprasad@chelsio.com \
--cc=hch@infradead.org \
--cc=jbottomley@parallels.com \
--cc=kxie@chelsio.com \
--cc=leedom@chelsio.com \
--cc=linux-scsi@vger.kernel.org \
--cc=manojmalviya@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox