Re: [PATHC] net: napi_reuse_skb() should check pfmemalloc

Roman Gushchin
2014-10-23T13:49:30Z

Signed-off-by: Roman Gushchin <klamm@yandex-team.ru>

--
@klamm

23.10.2014, 17:30, "Eric Dumazet" <eric.dumazet@gmail.com>:
> From: Eric Dumazet <edumazet@google.com>
>
> Do not reuse skb if it was pfmemalloc tainted, otherwise
> future frame might be dropped anyway.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> ---
>  net/core/dev.c |    4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index b793e3521a36..945bbd001359 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -4157,6 +4157,10 @@ EXPORT_SYMBOL(napi_gro_receive);
>
>  static void napi_reuse_skb(struct napi_struct *napi, struct sk_buff *skb)
>  {
> + if (unlikely(skb->pfmemalloc)) {
> + consume_skb(skb);
> + return;
> + }
>          __skb_pull(skb, skb_headlen(skb));
>          /* restore the reserve we had after netdev_alloc_skb_ip_align() */
>          skb_reserve(skb, NET_SKB_PAD + NET_IP_ALIGN - skb_headroom(skb));

------------------------------------------------------------------------------
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel&#174; Ethernet, visit http://communities.intel.com/community/wired