From mboxrd@z Thu Jan 1 00:00:00 1970 From: Varka Bhadram Subject: [PATCH net-next v2 1/6] ethernet: wiznet: remove unnecessary check Date: Thu, 23 Oct 2014 07:28:46 +0530 Message-ID: <1414029531-5067-2-git-send-email-varkab@cdac.in> References: <1414029531-5067-1-git-send-email-varkab@cdac.in> Cc: davem@davemloft.net, Varka Bhadram To: netdev@vger.kernel.org Return-path: Received: from mail-pa0-f46.google.com ([209.85.220.46]:40905 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752801AbaJWB7I (ORCPT ); Wed, 22 Oct 2014 21:59:08 -0400 Received: by mail-pa0-f46.google.com with SMTP id fa1so119506pad.5 for ; Wed, 22 Oct 2014 18:59:07 -0700 (PDT) In-Reply-To: <1414029531-5067-1-git-send-email-varkab@cdac.in> Sender: netdev-owner@vger.kernel.org List-ID: devm_ioremap_resource checks platform_get_resource() return value. We can remove the duplicate check here. Signed-off-by: Varka Bhadram --- drivers/net/ethernet/wiznet/w5100.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/wiznet/w5100.c b/drivers/net/ethernet/wiznet/w5100.c index 0f56b1c..70a930a 100644 --- a/drivers/net/ethernet/wiznet/w5100.c +++ b/drivers/net/ethernet/wiznet/w5100.c @@ -638,14 +638,12 @@ static int w5100_hw_probe(struct platform_device *pdev) } mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!mem) - return -ENXIO; - mem_size = resource_size(mem); - priv->base = devm_ioremap_resource(&pdev->dev, mem); if (IS_ERR(priv->base)) return PTR_ERR(priv->base); + mem_size = resource_size(mem); + spin_lock_init(&priv->reg_lock); priv->indirect = mem_size < W5100_BUS_DIRECT_SIZE; if (priv->indirect) { -- 1.7.9.5