From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matei Pavaluca Subject: [PATCH net-next v2 1/3] Add flow control support flags to gianfar's capabilities Date: Mon, 27 Oct 2014 10:42:42 +0200 Message-ID: <1414399364-22308-1-git-send-email-matei.pavaluca@freescale.com> Mime-Version: 1.0 Content-Type: text/plain Cc: "David S. Miller" , Claudiu Manoil , Pavaluca Matei-B46610 To: Return-path: Received: from mail-by2on0132.outbound.protection.outlook.com ([207.46.100.132]:14819 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751761AbaJ0Imy (ORCPT ); Mon, 27 Oct 2014 04:42:54 -0400 Sender: netdev-owner@vger.kernel.org List-ID: From: Pavaluca Matei-B46610 The phy device supports 802.3x flow control, but the specific flags are not set in the phy initialisation code. Flow control flags need to be added to the supported capabilities of the phydev by the driver. This is needed in order for ethtool to work ('ethtool -A' code checks for these flags) Signed-off-by: Pavaluca Matei --- v2: - none drivers/net/ethernet/freescale/gianfar.c | 3 +++ drivers/net/ethernet/freescale/gianfar.h | 4 +--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/freescale/gianfar.c b/drivers/net/ethernet/freescale/gianfar.c index 4fdf0aa..2485b74 100644 --- a/drivers/net/ethernet/freescale/gianfar.c +++ b/drivers/net/ethernet/freescale/gianfar.c @@ -1687,6 +1687,9 @@ static int init_phy(struct net_device *dev) priv->phydev->supported &= (GFAR_SUPPORTED | gigabit_support); priv->phydev->advertising = priv->phydev->supported; + /* Add support for flow control, but don't advertise it by default */ + priv->phydev->supported |= (SUPPORTED_Pause | SUPPORTED_Asym_Pause); + return 0; } diff --git a/drivers/net/ethernet/freescale/gianfar.h b/drivers/net/ethernet/freescale/gianfar.h index 2805cfb..6b00868 100644 --- a/drivers/net/ethernet/freescale/gianfar.h +++ b/drivers/net/ethernet/freescale/gianfar.h @@ -145,9 +145,7 @@ extern const char gfar_driver_version[]; | SUPPORTED_Autoneg \ | SUPPORTED_MII) -#define GFAR_SUPPORTED_GBIT (SUPPORTED_1000baseT_Full \ - | SUPPORTED_Pause \ - | SUPPORTED_Asym_Pause) +#define GFAR_SUPPORTED_GBIT SUPPORTED_1000baseT_Full /* TBI register addresses */ #define MII_TBICON 0x11 -- 1.7.11.7