From: Oliver Neukum <oneukum@suse.de>
To: David Miller <davem@davemloft.net>
Cc: olivier.blin@softathome.com, netdev@vger.kernel.org,
hayeswang@realtek.com, bjorn@mork.no
Subject: Re: [PATCH net 0/3] cdc-ether: handle promiscuous mode
Date: Tue, 28 Oct 2014 22:10:25 +0100 [thread overview]
Message-ID: <1414530625.29018.1.camel@linux-0dmf.site> (raw)
In-Reply-To: <20141028.154926.273240718595756465.davem@davemloft.net>
On Tue, 2014-10-28 at 15:49 -0400, David Miller wrote:
> From: Olivier Blin <olivier.blin@softathome.com>
> Date: Fri, 24 Oct 2014 19:42:59 +0200
>
> > Since kernel 3.16, my Lenovo USB network adapters (RTL8153) using
> > cdc-ether are not working anymore in a bridge.
> >
> > This is due to commit c472ab68ad67db23c9907a27649b7dc0899b61f9, which
> > resets the packet filter when the device is bound.
> >
> > The default packet filter set by cdc-ether does not include
> > promiscuous, while the adapter seemed to have promiscuous enabled by
> > default.
> >
> > This patch series allows to support promiscuous mode for cdc-ether, by
> > hooking into set_rx_mode.
> >
> > Incidentally, maybe this device should be handled by the r8152 driver,
> > but this patch series is still nice for other adapters.
>
> Can a usbnet expert please review this series?
Acked-by: Oliver Neukum <oneukum@suse.de>
Regards
Oliver
next prev parent reply other threads:[~2014-10-28 21:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 17:42 [PATCH net 0/3] cdc-ether: handle promiscuous mode Olivier Blin
2014-10-24 17:43 ` [PATCH net 1/3] usbnet: add a callback for set_rx_mode Olivier Blin
2014-10-24 17:43 ` [PATCH net 2/3] cdc-ether: extract usbnet_cdc_update_filter function Olivier Blin
2014-10-24 17:43 ` [PATCH net 3/3] cdc-ether: handle promiscuous mode with a set_rx_mode callback Olivier Blin
2014-10-27 10:02 ` [PATCH net 0/3] cdc-ether: handle promiscuous mode Oliver Neukum
2014-10-28 19:49 ` David Miller
2014-10-28 21:10 ` Oliver Neukum [this message]
2014-10-28 21:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414530625.29018.1.camel@linux-0dmf.site \
--to=oneukum@suse.de \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=hayeswang@realtek.com \
--cc=netdev@vger.kernel.org \
--cc=olivier.blin@softathome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).