From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Frederic Sowa Subject: Re: [PATCH v2 net-next] net: ipv6: Add a sysctl to make optimistic addresses useful candidates Date: Wed, 29 Oct 2014 15:34:38 +0100 Message-ID: <1414593278.24008.20.camel@localhost> References: <1414487474-18201-1-git-send-email-ek@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: "netdev@vger.kernel.org" , David Miller , Ben Hutchings , Lorenzo Colitti To: Erik Kline Return-path: Received: from out2-smtp.messagingengine.com ([66.111.4.26]:40340 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932834AbaJ2Oek (ORCPT ); Wed, 29 Oct 2014 10:34:40 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 4948B208DD for ; Wed, 29 Oct 2014 10:34:40 -0400 (EDT) In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: Hi Erik, On Mi, 2014-10-29 at 18:34 +0900, Erik Kline wrote: > Given that we spoke about this reduction in the number of netlink messages > earlier, do you still think it's an issue? No, it would be nice to have but as this is just a minor detail and complexity would be too high I am fine with your current solution. > The end result here is that for listeners on netlink sockets on systems > that (a) have optimistic dad built-in, (b) have optimistic dad enabled, and > (c) have use_optimistic set: they'll 2 notifications (with different flags) > for automatically added addresses on these interfaces. Ack, I see. > (Personally, given that we appear to send an RTM_NEWADDR when the address > gets deprecated (I think), I think sending one on every flag change of > interest is in keeping with existing behaviour.) It does make sense, I have no objections. Bye, Hannes