From: Paul Bolle <pebolle@tiscali.nl>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Valentin Rothberg <valentinrothberg@gmail.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
"John W. Linville" <linville@tuxdriver.com>,
Intel Linux Wireless <ilw@linux.intel.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: iwlwifi: mvm: BACKPORT_WANT_DEV_COREDUMP?
Date: Fri, 31 Oct 2014 10:17:45 +0100 [thread overview]
Message-ID: <1414747065.1964.15.camel@x220> (raw)
In-Reply-To: <1414746518.3014.18.camel@jlt4.sipsolutions.net>
On Fri, 2014-10-31 at 10:08 +0100, Johannes Berg wrote:
> On Fri, 2014-10-31 at 10:06 +0100, Paul Bolle wrote:
> > Perhaps you could also look into somehow guarding the call of
> > dev_coredumpm(), that this commit added, with checks for
> > CONFIG_DEV_COREDUMP. See, I had a quick look at all this and selecting
> > WANT_DEV_COREDUMP might not be enough, because DISABLE_DEV_COREDUMP can
> > still, well, disable DEV_COREDUMP. Or am I misreading the Kconfig
> > symbols that regulate DEV_COREDUMP?
>
> No, you're correctly reading that. However, the devcoredump header file
> provides simple functions in this case. That means there's some extra
> work (allocating and filling the buffer just to free it immediately) but
> it simplifies the code.
I see. More than a quick look was required here. Thanks for explaining
this!
Paul Bolle
prev parent reply other threads:[~2014-10-31 9:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 8:40 iwlwifi: mvm: BACKPORT_WANT_DEV_COREDUMP? Paul Bolle
2014-10-31 8:45 ` Johannes Berg
2014-10-31 9:06 ` Paul Bolle
2014-10-31 9:08 ` Johannes Berg
2014-10-31 9:17 ` Paul Bolle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1414747065.1964.15.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=emmanuel.grumbach@intel.com \
--cc=ilw@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).