From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Giuseppe Cavallaro <peppe.cavallaro@st.com>,
netdev@vger.kernel.org,
Kweh Hock Leong <hock.leong.kweh@intel.com>,
"David S . Miller" <davem@davemloft.net>,
Vince Bridgers <vbridgers2013@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: [PATCH] stmmac: fix sparse warnings
Date: Mon, 3 Nov 2014 19:28:53 +0200 [thread overview]
Message-ID: <1415035734-24163-1-git-send-email-andriy.shevchenko@linux.intel.com> (raw)
This patch fixes the following sparse warnings.
drivers/net/ethernet/stmicro/stmmac/enh_desc.c:381:30: warning: symbol 'enh_desc_ops' was not declared. Should it be static?
drivers/net/ethernet/stmicro/stmmac/norm_desc.c:253:30: warning: symbol 'ndesc_ops' was not declared. Should it be static?
drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c:141:33: warning: symbol 'stmmac_ptp' was not declared. Should it be static?
There is no functional change.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/net/ethernet/stmicro/stmmac/enh_desc.c | 2 ++
drivers/net/ethernet/stmicro/stmmac/norm_desc.c | 2 ++
drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c | 2 ++
3 files changed, 6 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/enh_desc.c b/drivers/net/ethernet/stmicro/stmmac/enh_desc.c
index 1e2bcf5..ddd4272 100644
--- a/drivers/net/ethernet/stmicro/stmmac/enh_desc.c
+++ b/drivers/net/ethernet/stmicro/stmmac/enh_desc.c
@@ -23,8 +23,10 @@
*******************************************************************************/
#include <linux/stmmac.h>
+
#include "common.h"
#include "descs_com.h"
+#include "stmmac.h"
static int enh_desc_get_tx_status(void *data, struct stmmac_extra_stats *x,
struct dma_desc *p, void __iomem *ioaddr)
diff --git a/drivers/net/ethernet/stmicro/stmmac/norm_desc.c b/drivers/net/ethernet/stmicro/stmmac/norm_desc.c
index 35ad4f4..46b882c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/norm_desc.c
+++ b/drivers/net/ethernet/stmicro/stmmac/norm_desc.c
@@ -23,8 +23,10 @@
*******************************************************************************/
#include <linux/stmmac.h>
+
#include "common.h"
#include "descs_com.h"
+#include "stmmac.h"
static int ndesc_get_tx_status(void *data, struct stmmac_extra_stats *x,
struct dma_desc *p, void __iomem *ioaddr)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
index 76ad214..88e0da3 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c
@@ -25,8 +25,10 @@
#include <linux/io.h>
#include <linux/delay.h>
+
#include "common.h"
#include "stmmac_ptp.h"
+#include "stmmac.h"
static void stmmac_config_hw_tstamping(void __iomem *ioaddr, u32 data)
{
--
2.1.1
next reply other threads:[~2014-11-03 17:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 17:28 Andy Shevchenko [this message]
2014-11-03 17:28 ` [PATCH] stmmac: remove custom implementation of print_hex_dump() Andy Shevchenko
2014-11-03 17:39 ` Joe Perches
2014-11-03 17:53 ` Andy Shevchenko
2014-11-03 18:11 ` Joe Perches
2014-11-04 16:35 ` [PATCH] stmmac: fix sparse warnings Giuseppe CAVALLARO
2014-11-04 21:59 ` David Miller
2014-11-05 9:03 ` Andy Shevchenko
2014-11-05 9:27 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415035734-24163-1-git-send-email-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=hock.leong.kweh@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=vbridgers2013@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).