* [PATCH net 1/2] geneve: Set GSO type on transmit. @ 2014-11-04 3:38 Jesse Gross 2014-11-04 3:38 ` [PATCH net 2/2] geneve: Unregister pernet subsys on module unload Jesse Gross 2014-11-05 20:01 ` [PATCH net 1/2] geneve: Set GSO type on transmit David Miller 0 siblings, 2 replies; 5+ messages in thread From: Jesse Gross @ 2014-11-04 3:38 UTC (permalink / raw) To: David S. Miller; +Cc: netdev, Andy Zhou Geneve does not currently set the inner protocol type when transmitting packets. This causes GSO segmentation to fail on NICs that do not support Geneve offloading. CC: Andy Zhou <azhou@nicira.com> Signed-off-by: Jesse Gross <jesse@nicira.com> --- net/ipv4/geneve.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/ipv4/geneve.c b/net/ipv4/geneve.c index 065cd94..6e5266c 100644 --- a/net/ipv4/geneve.c +++ b/net/ipv4/geneve.c @@ -144,6 +144,8 @@ int geneve_xmit_skb(struct geneve_sock *gs, struct rtable *rt, gnvh = (struct genevehdr *)__skb_push(skb, sizeof(*gnvh) + opt_len); geneve_build_header(gnvh, tun_flags, vni, opt_len, opt); + skb_set_inner_protocol(skb, htons(ETH_P_TEB)); + return udp_tunnel_xmit_skb(gs->sock, rt, skb, src, dst, tos, ttl, df, src_port, dst_port, xnet); } -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH net 2/2] geneve: Unregister pernet subsys on module unload. 2014-11-04 3:38 [PATCH net 1/2] geneve: Set GSO type on transmit Jesse Gross @ 2014-11-04 3:38 ` Jesse Gross 2014-11-05 10:08 ` Nicolas Dichtel 2014-11-05 20:01 ` David Miller 2014-11-05 20:01 ` [PATCH net 1/2] geneve: Set GSO type on transmit David Miller 1 sibling, 2 replies; 5+ messages in thread From: Jesse Gross @ 2014-11-04 3:38 UTC (permalink / raw) To: David S. Miller; +Cc: netdev, Andy Zhou The pernet ops aren't ever unregistered, which causes a memory leak and an OOPs if the module is ever reinserted. CC: Andy Zhou <azhou@nicira.com> Signed-off-by: Jesse Gross <jesse@nicira.com> --- net/ipv4/geneve.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv4/geneve.c b/net/ipv4/geneve.c index 6e5266c..dedb21e 100644 --- a/net/ipv4/geneve.c +++ b/net/ipv4/geneve.c @@ -366,6 +366,7 @@ late_initcall(geneve_init_module); static void __exit geneve_cleanup_module(void) { destroy_workqueue(geneve_wq); + unregister_pernet_subsys(&geneve_net_ops); } module_exit(geneve_cleanup_module); -- 1.9.1 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net 2/2] geneve: Unregister pernet subsys on module unload. 2014-11-04 3:38 ` [PATCH net 2/2] geneve: Unregister pernet subsys on module unload Jesse Gross @ 2014-11-05 10:08 ` Nicolas Dichtel 2014-11-05 20:01 ` David Miller 1 sibling, 0 replies; 5+ messages in thread From: Nicolas Dichtel @ 2014-11-05 10:08 UTC (permalink / raw) To: Jesse Gross, David S. Miller; +Cc: netdev, Andy Zhou Le 04/11/2014 04:38, Jesse Gross a écrit : > The pernet ops aren't ever unregistered, which causes a memory > leak and an OOPs if the module is ever reinserted. > > CC: Andy Zhou <azhou@nicira.com> > Signed-off-by: Jesse Gross <jesse@nicira.com> Fixes: 0b5e8b8eeae4 ("net: Add Geneve tunneling protocol driver") Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net 2/2] geneve: Unregister pernet subsys on module unload. 2014-11-04 3:38 ` [PATCH net 2/2] geneve: Unregister pernet subsys on module unload Jesse Gross 2014-11-05 10:08 ` Nicolas Dichtel @ 2014-11-05 20:01 ` David Miller 1 sibling, 0 replies; 5+ messages in thread From: David Miller @ 2014-11-05 20:01 UTC (permalink / raw) To: jesse; +Cc: netdev, azhou From: Jesse Gross <jesse@nicira.com> Date: Mon, 3 Nov 2014 19:38:38 -0800 > The pernet ops aren't ever unregistered, which causes a memory > leak and an OOPs if the module is ever reinserted. > > CC: Andy Zhou <azhou@nicira.com> > Signed-off-by: Jesse Gross <jesse@nicira.com> Applied. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH net 1/2] geneve: Set GSO type on transmit. 2014-11-04 3:38 [PATCH net 1/2] geneve: Set GSO type on transmit Jesse Gross 2014-11-04 3:38 ` [PATCH net 2/2] geneve: Unregister pernet subsys on module unload Jesse Gross @ 2014-11-05 20:01 ` David Miller 1 sibling, 0 replies; 5+ messages in thread From: David Miller @ 2014-11-05 20:01 UTC (permalink / raw) To: jesse; +Cc: netdev, azhou From: Jesse Gross <jesse@nicira.com> Date: Mon, 3 Nov 2014 19:38:37 -0800 > Geneve does not currently set the inner protocol type when > transmitting packets. This causes GSO segmentation to fail on NICs > that do not support Geneve offloading. > > CC: Andy Zhou <azhou@nicira.com> > Signed-off-by: Jesse Gross <jesse@nicira.com> Applied. ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-05 20:01 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2014-11-04 3:38 [PATCH net 1/2] geneve: Set GSO type on transmit Jesse Gross 2014-11-04 3:38 ` [PATCH net 2/2] geneve: Unregister pernet subsys on module unload Jesse Gross 2014-11-05 10:08 ` Nicolas Dichtel 2014-11-05 20:01 ` David Miller 2014-11-05 20:01 ` [PATCH net 1/2] geneve: Set GSO type on transmit David Miller
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).