From: Jesse Gross <jesse@nicira.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Andy Zhou <azhou@nicira.com>
Subject: [PATCH net 2/2] geneve: Unregister pernet subsys on module unload.
Date: Mon, 3 Nov 2014 19:38:38 -0800 [thread overview]
Message-ID: <1415072318-64442-2-git-send-email-jesse@nicira.com> (raw)
In-Reply-To: <1415072318-64442-1-git-send-email-jesse@nicira.com>
The pernet ops aren't ever unregistered, which causes a memory
leak and an OOPs if the module is ever reinserted.
CC: Andy Zhou <azhou@nicira.com>
Signed-off-by: Jesse Gross <jesse@nicira.com>
---
net/ipv4/geneve.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/ipv4/geneve.c b/net/ipv4/geneve.c
index 6e5266c..dedb21e 100644
--- a/net/ipv4/geneve.c
+++ b/net/ipv4/geneve.c
@@ -366,6 +366,7 @@ late_initcall(geneve_init_module);
static void __exit geneve_cleanup_module(void)
{
destroy_workqueue(geneve_wq);
+ unregister_pernet_subsys(&geneve_net_ops);
}
module_exit(geneve_cleanup_module);
--
1.9.1
next prev parent reply other threads:[~2014-11-04 3:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 3:38 [PATCH net 1/2] geneve: Set GSO type on transmit Jesse Gross
2014-11-04 3:38 ` Jesse Gross [this message]
2014-11-05 10:08 ` [PATCH net 2/2] geneve: Unregister pernet subsys on module unload Nicolas Dichtel
2014-11-05 20:01 ` David Miller
2014-11-05 20:01 ` [PATCH net 1/2] geneve: Set GSO type on transmit David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415072318-64442-2-git-send-email-jesse@nicira.com \
--to=jesse@nicira.com \
--cc=azhou@nicira.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).