netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christian Hesse <mail@eworm.de>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, Christian Hesse <mail@eworm.de>
Subject: [PATCH 1/1] ip-link: in human readable output use dynamic precision length
Date: Tue,  4 Nov 2014 10:39:50 +0100	[thread overview]
Message-ID: <1415093990-22632-1-git-send-email-mail@eworm.de> (raw)

Now that we use floating point numbers for human readable output we can
calculate precision length on the fly.
---
 ip/ipaddress.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ip/ipaddress.c b/ip/ipaddress.c
index e240bb5..0ddcb0d 100644
--- a/ip/ipaddress.c
+++ b/ip/ipaddress.c
@@ -343,8 +343,8 @@ static void print_num(FILE *fp, unsigned width, uint64_t count)
 		++prefix;
 	}
 
-	snprintf(buf, sizeof(buf), "%.1f%c%s", (double) count / powi, 
-		 *prefix, use_iec ? "i" : "");
+	snprintf(buf, sizeof(buf), "%.*f%c%s", 3 - snprintf(NULL, 0, "%"PRIu64, count / powi),
+		(double) count / powi, *prefix, use_iec ? "i" : "");
 
 	fprintf(fp, "%-*s ", width, buf);
 }
-- 
2.1.3

             reply	other threads:[~2014-11-04  9:41 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04  9:39 Christian Hesse [this message]
2014-11-04 10:44 ` [PATCH 1/1] ip-link: in human readable output use dynamic precision length Christian Hesse
2014-11-04 10:50   ` [PATCH v2 " Christian Hesse
2014-11-04 11:06     ` David Laight
2014-11-04 21:10       ` Christian Hesse
2014-11-04 21:17         ` [PATCH v3 " Christian Hesse
2014-11-05  9:30         ` [PATCH v2 " David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415093990-22632-1-git-send-email-mail@eworm.de \
    --to=mail@eworm.de \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).