From: Ian Campbell <ijc@hellion.org.uk>
To: Karl Beldan <karl.beldan@gmail.com>
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
netdev@vger.kernel.org, David Miller <davem@davemloft.net>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Lior Amsalem <alior@marvell.com>,
Nadav Haklai <nadavh@marvell.com>,
764162@bugs.debian.org
Subject: Bug#764162: [PATCH 0/1] mv643xx_eth: Disable TSO by default
Date: Wed, 05 Nov 2014 08:39:26 +0000 [thread overview]
Message-ID: <1415176766.31613.7.camel@hellion.org.uk> (raw)
In-Reply-To: <20141104142020.GA6728@magnum.frso.rivierawaves.com>
On Tue, 2014-11-04 at 15:20 +0100, Karl Beldan wrote:
> On Sat, Nov 01, 2014 at 12:30:19PM -0300, Ezequiel Garcia wrote:
> > Several users ([1], [2]) have been reporting data corruption with TSO on
> > Kirkwood platforms (i.e. using the mv643xx_eth driver).
> >
> > Until we manage to find what's causing this, this simple patch will make
> > the TSO path disabled by default. This patch should be queued for stable,
> > fixing the TSO feature introduced in v3.16.
> >
> > The corruption itself is very easy to reproduce: checking md5sum on a mounted
> > NFS directory gives a different result each time. Same tests using the mvneta
> > driver (Armada 370/38x/XP SoC) pass with no issues.
> >
> > Frankly, I'm a bit puzzled about this, and so any ideas or debugging hints
> > are well received.
> >
>
> Hi,
>
> Can you try this :
It fixes things for me, thanks!
Tested-by: Ian Campbell <ijc@hellion.org.uk>
> @@ -1067,7 +1082,8 @@ static int txq_reclaim(struct tx_queue *txq, int budget, int force)
> txq->tx_desc_count--;
>
> skb = NULL;
> - if (cmd_sts & TX_LAST_DESC)
> + if ((cmd_sts & (TX_LAST_DESC | TX_ENABLE_INTERRUPT)) ==
> + (TX_LAST_DESC | TX_ENABLE_INTERRUPT))
> skb = __skb_dequeue(&txq->tx_skb);
>
> if (cmd_sts & ERROR_SUMMARY) {
>
next prev parent reply other threads:[~2014-11-05 8:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 15:30 [PATCH 0/1] mv643xx_eth: Disable TSO by default Ezequiel Garcia
2014-11-01 15:30 ` [PATCH 1/1] net: mv643xx_eth: Make TSO disabled " Ezequiel Garcia
2014-11-01 17:00 ` Thomas Petazzoni
2014-11-01 17:40 ` David Miller
2014-11-01 17:26 ` [PATCH 0/1] mv643xx_eth: Disable TSO " Eric Dumazet
2014-11-01 17:33 ` Thomas Petazzoni
2014-11-01 18:01 ` Eric Dumazet
2014-11-01 17:37 ` Eric Dumazet
2014-11-01 19:05 ` Ezequiel Garcia
2014-11-01 17:42 ` David Miller
2014-11-03 14:51 ` David Laight
2014-11-03 19:04 ` Eric Dumazet
2014-11-04 14:20 ` Karl Beldan
2014-11-05 8:39 ` Ian Campbell [this message]
2014-11-05 10:09 ` Karl Beldan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415176766.31613.7.camel@hellion.org.uk \
--to=ijc@hellion.org.uk \
--cc=764162@bugs.debian.org \
--cc=alior@marvell.com \
--cc=davem@davemloft.net \
--cc=ezequiel.garcia@free-electrons.com \
--cc=gregory.clement@free-electrons.com \
--cc=karl.beldan@gmail.com \
--cc=nadavh@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).