From: Joe Perches <joe@perches.com>
To: Hariprasad Shenai <hariprasad@chelsio.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, leedom@chelsio.com,
anish@chelsio.com, praveenm@chelsio.com, nirranjan@chelsio.com,
kumaras@chelsio.com, Jay Vosburgh <j.vosburgh@gmail.com>,
Veaceslav Falico <vfalico@gmail.com>,
Andy Gospodarek <andy@greyhouse.net>
Subject: [PATCH net-next] cxgb4: Remove unnecessary struct in6_addr * casts
Date: Thu, 06 Nov 2014 20:46:14 -0800 [thread overview]
Message-ID: <1415335574.23530.4.camel@perches.com> (raw)
In-Reply-To: <1415333125-10635-2-git-send-email-hariprasad@chelsio.com>
Just use the address of the in6_addr.
Signed-off-by: Joe Perches <joe@perches.com>
---
> diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
[]
> #include <../drivers/net/bonding/bonding.h>
This include path seems unfortunate so I looked
at the code a bit. I don't see an easy way to change it.
Maybe some of bonding.h should be moved into a new file
like 'include/net/bonding.h' or something.
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
index 8520d55..8bc19b2 100644
--- a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
+++ b/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c
@@ -4395,8 +4395,7 @@ static int clip_add(struct net_device *event_dev, struct inet6_ifaddr *ifa,
if (cxgb4_netdev(event_dev)) {
switch (event) {
case NETDEV_UP:
- ret = cxgb4_clip_get(event_dev,
- (const struct in6_addr *)ifa->addr.s6_addr);
+ ret = cxgb4_clip_get(event_dev, &ifa->addr);
if (ret < 0) {
rcu_read_unlock();
return ret;
@@ -4404,8 +4403,7 @@ static int clip_add(struct net_device *event_dev, struct inet6_ifaddr *ifa,
ret = NOTIFY_OK;
break;
case NETDEV_DOWN:
- cxgb4_clip_release(event_dev,
- (const struct in6_addr *)ifa->addr.s6_addr);
+ cxgb4_clip_release(event_dev, &ifa->addr);
ret = NOTIFY_OK;
break;
default:
@@ -4474,8 +4472,7 @@ static int update_dev_clip(struct net_device *root_dev, struct net_device *dev)
read_lock_bh(&idev->lock);
list_for_each_entry(ifa, &idev->addr_list, if_list) {
- ret = cxgb4_clip_get(dev,
- (const struct in6_addr *)ifa->addr.s6_addr);
+ ret = cxgb4_clip_get(dev, &ifa->addr);
if (ret < 0)
break;
}
next prev parent reply other threads:[~2014-11-07 4:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 4:05 [PATCHv3 net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros Hariprasad Shenai
2014-11-07 4:05 ` [PATCHv3 net-next 1/3] cxgb4: Add cxgb4_debugfs.c, move all debugfs code to new file Hariprasad Shenai
2014-11-07 4:46 ` Joe Perches [this message]
2014-11-10 18:28 ` [PATCH net-next] cxgb4: Remove unnecessary struct in6_addr * casts David Miller
2014-11-10 18:48 ` Joe Perches
2014-11-10 19:09 ` David Miller
2014-11-10 19:23 ` Joe Perches
2014-11-07 4:05 ` [PATCHv3 net-next 2/3] cxgb4: Cleanup macros so they follow the same style and look consistent Hariprasad Shenai
2014-11-07 4:05 ` [PATCHv3 net-next 3/3] cxgb4: Cleanup macros so they follow the same style and look consistent, part 2 Hariprasad Shenai
2014-11-10 17:57 ` [PATCHv3 net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415335574.23530.4.camel@perches.com \
--to=joe@perches.com \
--cc=andy@greyhouse.net \
--cc=anish@chelsio.com \
--cc=davem@davemloft.net \
--cc=hariprasad@chelsio.com \
--cc=j.vosburgh@gmail.com \
--cc=kumaras@chelsio.com \
--cc=leedom@chelsio.com \
--cc=netdev@vger.kernel.org \
--cc=nirranjan@chelsio.com \
--cc=praveenm@chelsio.com \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).