netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, nhorman@tuxdriver.com, andy@greyhouse.net,
	tgraf@suug.ch, dborkman@redhat.com, ogerlitz@mellanox.com,
	jesse@nicira.com, pshelar@nicira.com, azhou@nicira.com,
	ben@decadent.org.uk, stephen@networkplumber.org,
	jeffrey.t.kirsher@intel.com, vyasevic@redhat.com,
	xiyou.wangcong@gmail.com, john.r.fastabend@intel.com,
	edumazet@google.com, jhs@mojatatu.com, sfeldma@gmail.com,
	f.fainelli@gmail.com, roopa@cumulusnetworks.com,
	linville@tuxdriver.com, jasowang@redhat.com,
	ebiederm@xmission.com, nicolas.dichtel@6wind.com,
	ryazanov.s.a@gmail.com, buytenh@wantstofly.org,
	aviadr@mellanox.com, nbd@openwrt.org,
	alexei.starovoitov@gmail.com, Neil.Jerram@metaswitch.com,
	ronye@mellanox.com, simon.horman@netronome.com,
	alexander.h.duyck@redhat.com, john.ronciak@intel.com,
	mleitner@redhat.com, shrijeet@gmail.com,
	gospo@cumulusnetworks.com, bcrl@kvack.org
Subject: [patch net-next v2 03/10] rtnl: expose physical switch id for particular device
Date: Sun,  9 Nov 2014 11:51:13 +0100	[thread overview]
Message-ID: <1415530280-9190-4-git-send-email-jiri@resnulli.us> (raw)
In-Reply-To: <1415530280-9190-1-git-send-email-jiri@resnulli.us>

The netdevice represents a port in a switch, it will expose
IFLA_PHYS_SWITCH_ID value via rtnl. Two netdevices with the same value
belong to one physical switch.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
 include/uapi/linux/if_link.h |  1 +
 net/core/rtnetlink.c         | 26 +++++++++++++++++++++++++-
 2 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
index 7072d83..4163753 100644
--- a/include/uapi/linux/if_link.h
+++ b/include/uapi/linux/if_link.h
@@ -145,6 +145,7 @@ enum {
 	IFLA_CARRIER,
 	IFLA_PHYS_PORT_ID,
 	IFLA_CARRIER_CHANGES,
+	IFLA_PHYS_SWITCH_ID,
 	__IFLA_MAX
 };
 
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 1087c6d..f839354 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -43,6 +43,7 @@
 
 #include <linux/inet.h>
 #include <linux/netdevice.h>
+#include <net/switchdev.h>
 #include <net/ip.h>
 #include <net/protocol.h>
 #include <net/arp.h>
@@ -868,7 +869,8 @@ static noinline size_t if_nlmsg_size(const struct net_device *dev,
 	       + rtnl_port_size(dev, ext_filter_mask) /* IFLA_VF_PORTS + IFLA_PORT_SELF */
 	       + rtnl_link_get_size(dev) /* IFLA_LINKINFO */
 	       + rtnl_link_get_af_size(dev) /* IFLA_AF_SPEC */
-	       + nla_total_size(MAX_PHYS_ITEM_ID_LEN); /* IFLA_PHYS_PORT_ID */
+	       + nla_total_size(MAX_PHYS_ITEM_ID_LEN) /* IFLA_PHYS_PORT_ID */
+	       + nla_total_size(MAX_PHYS_ITEM_ID_LEN); /* IFLA_PHYS_SWITCH_ID */
 }
 
 static int rtnl_vf_ports_fill(struct sk_buff *skb, struct net_device *dev)
@@ -967,6 +969,24 @@ static int rtnl_phys_port_id_fill(struct sk_buff *skb, struct net_device *dev)
 	return 0;
 }
 
+static int rtnl_phys_switch_id_fill(struct sk_buff *skb, struct net_device *dev)
+{
+	int err;
+	struct netdev_phys_item_id psid;
+
+	err = netdev_sw_parent_id_get(dev, &psid);
+	if (err) {
+		if (err == -EOPNOTSUPP)
+			return 0;
+		return err;
+	}
+
+	if (nla_put(skb, IFLA_PHYS_SWITCH_ID, psid.id_len, psid.id))
+		return -EMSGSIZE;
+
+	return 0;
+}
+
 static int rtnl_fill_ifinfo(struct sk_buff *skb, struct net_device *dev,
 			    int type, u32 pid, u32 seq, u32 change,
 			    unsigned int flags, u32 ext_filter_mask)
@@ -1039,6 +1059,9 @@ static int rtnl_fill_ifinfo(struct sk_buff *skb, struct net_device *dev,
 	if (rtnl_phys_port_id_fill(skb, dev))
 		goto nla_put_failure;
 
+	if (rtnl_phys_switch_id_fill(skb, dev))
+		goto nla_put_failure;
+
 	attr = nla_reserve(skb, IFLA_STATS,
 			sizeof(struct rtnl_link_stats));
 	if (attr == NULL)
@@ -1198,6 +1221,7 @@ static const struct nla_policy ifla_policy[IFLA_MAX+1] = {
 	[IFLA_NUM_RX_QUEUES]	= { .type = NLA_U32 },
 	[IFLA_PHYS_PORT_ID]	= { .type = NLA_BINARY, .len = MAX_PHYS_ITEM_ID_LEN },
 	[IFLA_CARRIER_CHANGES]	= { .type = NLA_U32 },  /* ignored */
+	[IFLA_PHYS_SWITCH_ID]	= { .type = NLA_BINARY, .len = MAX_PHYS_ITEM_ID_LEN },
 };
 
 static const struct nla_policy ifla_info_policy[IFLA_INFO_MAX+1] = {
-- 
1.9.3

  parent reply	other threads:[~2014-11-09 10:51 UTC|newest]

Thread overview: 100+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-09 10:51 [patch net-next v2 00/10] introduce rocker switch driver with hardware accelerated datapath api - phase 1: bridge fdb offload Jiri Pirko
2014-11-09 10:51 ` [patch net-next v2 01/10] net: rename netdev_phys_port_id to more generic name Jiri Pirko
2014-11-10  3:35   ` Jamal Hadi Salim
2014-11-10  5:23     ` David Miller
2014-11-10 12:06       ` Jamal Hadi Salim
2014-11-10 12:33         ` Daniel Borkmann
2014-11-10 12:56           ` Jamal Hadi Salim
2014-11-10 16:28         ` David Miller
2014-11-10  7:43     ` Jiri Pirko
2014-11-10 12:17       ` Jamal Hadi Salim
2014-11-10 13:16         ` Jiri Pirko
2014-11-10 13:20           ` Jamal Hadi Salim
2014-11-10 16:28         ` David Miller
2014-11-10 19:03           ` Jamal Hadi Salim
2014-11-10 21:57   ` John Fastabend
2014-11-09 10:51 ` [patch net-next v2 02/10] net: introduce generic switch devices support Jiri Pirko
2014-11-10 21:59   ` John Fastabend
2014-11-11 15:11     ` Jiri Pirko
2014-11-11  9:49   ` M. Braun
2014-11-11 10:04     ` Jiri Pirko
2014-11-19 13:28   ` Roopa Prabhu
2014-11-19 13:46     ` Jiri Pirko
2014-11-19 13:59       ` Roopa Prabhu
2014-11-20 15:55         ` Andy Gospodarek
2014-11-21  7:16           ` Jiri Pirko
2014-11-09 10:51 ` Jiri Pirko [this message]
2014-11-10  3:43   ` [patch net-next v2 03/10] rtnl: expose physical switch id for particular device Jamal Hadi Salim
2014-11-10  7:45     ` Jiri Pirko
2014-11-10 17:58   ` Roopa Prabhu
2014-11-10 20:02     ` Scott Feldman
2014-11-11 13:55       ` Roopa Prabhu
2014-11-10 22:14     ` Jiri Pirko
2014-11-10 22:31       ` John Fastabend
2014-11-10 22:01   ` John Fastabend
2014-11-09 10:51 ` [patch net-next v2 04/10] net-sysfs: " Jiri Pirko
2014-11-10 22:01   ` John Fastabend
2014-11-09 10:51 ` [patch net-next v2 05/10] rocker: introduce rocker switch driver Jiri Pirko
2014-11-10 22:04   ` John Fastabend
2014-11-11 14:29     ` Thomas Graf
2014-11-11 15:19       ` Jiri Pirko
2014-11-11 15:32         ` Thomas Graf
2014-11-11 15:40           ` Jiri Pirko
2014-11-11 16:10             ` Thomas Graf
2014-11-27 14:09             ` Florian Fainelli
2014-11-11 15:41           ` Roopa Prabhu
2014-11-11 15:44             ` John Fastabend
2014-11-11 15:28     ` Jiri Pirko
2014-11-09 10:51 ` [patch net-next v2 06/10] bridge: introduce fdb offloading via switchdev Jiri Pirko
2014-11-10  3:47   ` Jamal Hadi Salim
2014-11-10  8:15     ` Jiri Pirko
2014-11-10  9:30       ` Scott Feldman
2014-11-10 12:47       ` Jamal Hadi Salim
2014-11-10 13:47         ` Jiri Pirko
2014-11-10 19:13           ` Jamal Hadi Salim
2014-11-10 13:51       ` Thomas Graf
2014-11-10 17:30         ` Andy Gospodarek
2014-11-10 19:03           ` Roopa Prabhu
2014-11-12 13:43             ` Jiri Pirko
2014-11-09 10:51 ` [patch net-next v2 07/10] bridge: call netdev_sw_port_stp_update when bridge port STP status changes Jiri Pirko
2014-11-10 13:11   ` Jamal Hadi Salim
2014-11-10 14:04     ` Thomas Graf
2014-11-10 19:20       ` Jamal Hadi Salim
2014-11-10 15:59     ` Roopa Prabhu
2014-11-09 10:51 ` [patch net-next v2 08/10] bridge: add API to notify bridge driver of learned FBD on offloaded device Jiri Pirko
2014-11-11 14:21   ` Roopa Prabhu
2014-11-11 17:38     ` Scott Feldman
2014-11-11 21:43       ` Roopa Prabhu
2014-11-09 10:51 ` [patch net-next v2 09/10] rocker: implement rocker ofdpa flow table manipulation Jiri Pirko
2014-11-09 10:51 ` [patch net-next v2 10/10] rocker: implement L2 bridge offloading Jiri Pirko
2014-11-10  3:53   ` Jamal Hadi Salim
2014-11-10  8:18     ` Jiri Pirko
2014-11-10  9:10       ` Nicolas Dichtel
2014-11-10  8:46     ` Scott Feldman
2014-11-10 12:27       ` Jamal Hadi Salim
2014-11-10 16:12         ` Roopa Prabhu
2014-11-10 17:36           ` Scott Feldman
2014-11-10 18:35             ` Roopa Prabhu
2014-11-10 19:27               ` Jamal Hadi Salim
2014-11-10 19:47                 ` Scott Feldman
2014-11-10 21:14                   ` Jamal Hadi Salim
2014-11-10 19:25             ` Jamal Hadi Salim
2014-11-10 17:22         ` Scott Feldman
2014-11-09 16:40 ` [patch net-next] bridge: rename fdb_*_hw to fdb_*_hw_addr to avoid confusion Jiri Pirko
2014-11-11  2:33   ` David Miller
2014-11-11  7:20     ` Jiri Pirko
2014-11-10  3:31 ` [patch net-next v2 00/10] introduce rocker switch driver with hardware accelerated datapath api - phase 1: bridge fdb offload Jamal Hadi Salim
2014-11-10  3:46   ` Simon Horman
2014-11-10  4:03     ` Jamal Hadi Salim
2014-11-10  4:58       ` Simon Horman
2014-11-10 22:23         ` John Fastabend
2014-11-11  8:51           ` Simon Horman
2014-11-13  5:44           ` Simon Horman
2014-11-13  6:31             ` John Fastabend
2014-11-21  2:01               ` Simon Horman
2014-11-21  7:20                 ` John Fastabend
2014-11-10  7:23   ` Jiri Pirko
2014-11-10 12:16     ` Jamal Hadi Salim
2014-11-10 13:12       ` Jiri Pirko
2014-11-10 16:48 ` Thomas Graf
2014-11-12 13:44 ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1415530280-9190-4-git-send-email-jiri@resnulli.us \
    --to=jiri@resnulli.us \
    --cc=Neil.Jerram@metaswitch.com \
    --cc=alexander.h.duyck@redhat.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andy@greyhouse.net \
    --cc=aviadr@mellanox.com \
    --cc=azhou@nicira.com \
    --cc=bcrl@kvack.org \
    --cc=ben@decadent.org.uk \
    --cc=buytenh@wantstofly.org \
    --cc=davem@davemloft.net \
    --cc=dborkman@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=gospo@cumulusnetworks.com \
    --cc=jasowang@redhat.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse@nicira.com \
    --cc=jhs@mojatatu.com \
    --cc=john.r.fastabend@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=linville@tuxdriver.com \
    --cc=mleitner@redhat.com \
    --cc=nbd@openwrt.org \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=nicolas.dichtel@6wind.com \
    --cc=ogerlitz@mellanox.com \
    --cc=pshelar@nicira.com \
    --cc=ronye@mellanox.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=ryazanov.s.a@gmail.com \
    --cc=sfeldma@gmail.com \
    --cc=shrijeet@gmail.com \
    --cc=simon.horman@netronome.com \
    --cc=stephen@networkplumber.org \
    --cc=tgraf@suug.ch \
    --cc=vyasevic@redhat.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).