From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Alexander Duyck <alexander.h.duyck@redhat.com>,
"linux-arch@vger.kernel.org" <linux-arch@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Peter Zijlstra <peterz@infradead.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Ingo Molnar <mingo@kernel.org>,
Michael Neuling <mikey@neuling.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
donald.c.skidmore@intel.com, matthew.vick@intel.com,
Geert Uytterhoeven <geert@linux-m68k.org>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Francois Romieu <romieu@fr.zoreil.com>,
Paul McKenney <paulmck@linux.vnet.ibm.com>,
nic_swsd@realtek.com, Will Deacon <will.deacon@arm.com>,
Michael Ellerman <michael@ellerman.id.au>,
Tony Luck <tony.luck@intel.com>, Oleg Nesterov <oleg@redhat.com>,
Martin Schwidefsky <sch
Subject: Re: [PATCH 2/4] arch: Add lightweight memory barriers fast_rmb() and fast_wmb()
Date: Tue, 18 Nov 2014 11:41:45 +1100 [thread overview]
Message-ID: <1416271305.18381.19.camel@kernel.crashing.org> (raw)
In-Reply-To: <CA+55aFxZ9dhB074p3OAQLyQ53TuRjVOo33h6OOda1soh-9xxnQ@mail.gmail.com>
On Mon, 2014-11-17 at 12:52 -0800, Linus Torvalds wrote:
> Maybe "dma_*mb()" would be acceptable, and ends up having the same
> naming convention as "smb_*mb()", and explains what it's about.
Yes, that was what I was about to suggest as well.
> And yes, in the same spirit, it would probably be good to try to
> eventually get rid of the plain "*mb()" functions, and perhaps call
> them "mmio_*mb()" to clarify that they are about ordering memory wrt
> mmio.
It will always be somewhat unclear to users who don't read the doc
anyway :)
IE. the dma_* ones do only DMA vs DMA (or vs other processors) but the
mmio_* one do anything vs anything. Not a huge deal tho. I still like
dma_* for Alexander's new stuff but I wouldn't bother with changing the
existing ones.
Ben.
next prev parent reply other threads:[~2014-11-18 0:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 17:17 [PATCH 0/4] Add lightweight memory barriers fast_rmb() and fast_wmb() Alexander Duyck
2014-11-17 17:17 ` [PATCH 1/4] arch: Cleanup read_barrier_depends() and comments Alexander Duyck
2014-11-17 17:18 ` [PATCH 2/4] arch: Add lightweight memory barriers fast_rmb() and fast_wmb() Alexander Duyck
2014-11-17 20:04 ` Benjamin Herrenschmidt
2014-11-17 20:24 ` Alexander Duyck
2014-11-18 0:39 ` Benjamin Herrenschmidt
2014-11-18 3:13 ` Alexander Duyck
2014-11-18 11:58 ` Will Deacon
2014-11-18 16:20 ` Alexander Duyck
2014-11-18 16:48 ` Will Deacon
2014-11-18 21:07 ` Benjamin Herrenschmidt
2014-11-17 20:18 ` Paul E. McKenney
2014-11-17 21:11 ` Alexander Duyck
2014-11-17 23:17 ` Paul E. McKenney
2014-11-18 3:33 ` Alexander Duyck
2014-11-18 0:38 ` Benjamin Herrenschmidt
2014-11-17 20:52 ` Linus Torvalds
2014-11-17 21:54 ` Alexander Duyck
2014-11-18 0:43 ` Benjamin Herrenschmidt
2014-11-18 0:41 ` Benjamin Herrenschmidt [this message]
2014-11-17 17:18 ` [PATCH 3/4] r8169: Use fast_rmb() and fast_wmb() for DescOwn checks Alexander Duyck
2014-11-17 17:18 ` [PATCH 4/4] fm10k/igb/ixgbe: Use fast_rmb on Rx descriptor reads Alexander Duyck
2014-11-17 21:32 ` Jeff Kirsher
2014-11-18 9:57 ` [PATCH 0/4] Add lightweight memory barriers fast_rmb() and fast_wmb() David Laight
2014-11-18 15:44 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416271305.18381.19.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=alexander.h.duyck@redhat.com \
--cc=donald.c.skidmore@intel.com \
--cc=geert@linux-m68k.org \
--cc=heiko.carstens@de.ibm.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=matthew.vick@intel.com \
--cc=michael@ellerman.id.au \
--cc=mikey@neuling.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=romieu@fr.zoreil.com \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).