From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, linux-can@vger.kernel.org,
kernel@pengutronix.de,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Sudip Mukherjee <sudip@vectorindia.org>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH 05/17] can: remove unused variable
Date: Tue, 18 Nov 2014 21:37:35 +0100 [thread overview]
Message-ID: <1416343067-9810-6-git-send-email-mkl@pengutronix.de> (raw)
In-Reply-To: <1416343067-9810-1-git-send-email-mkl@pengutronix.de>
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
these variable were only assigned some values, but then never
reused again.
so they are safe to be removed.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/sja1000/kvaser_pci.c | 5 +----
drivers/net/can/usb/ems_usb.c | 3 +--
drivers/net/can/usb/esd_usb2.c | 2 --
3 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/net/can/sja1000/kvaser_pci.c b/drivers/net/can/sja1000/kvaser_pci.c
index 8ff3424d5147..15c00faeec61 100644
--- a/drivers/net/can/sja1000/kvaser_pci.c
+++ b/drivers/net/can/sja1000/kvaser_pci.c
@@ -214,7 +214,7 @@ static int kvaser_pci_add_chan(struct pci_dev *pdev, int channel,
struct net_device *dev;
struct sja1000_priv *priv;
struct kvaser_pci *board;
- int err, init_step;
+ int err;
dev = alloc_sja1000dev(sizeof(struct kvaser_pci));
if (dev == NULL)
@@ -235,7 +235,6 @@ static int kvaser_pci_add_chan(struct pci_dev *pdev, int channel,
if (channel == 0) {
board->xilinx_ver =
ioread8(board->res_addr + XILINX_VERINT) >> 4;
- init_step = 2;
/* Assert PTADR# - we're in passive mode so the other bits are
not important */
@@ -264,8 +263,6 @@ static int kvaser_pci_add_chan(struct pci_dev *pdev, int channel,
priv->irq_flags = IRQF_SHARED;
dev->irq = pdev->irq;
- init_step = 4;
-
dev_info(&pdev->dev, "reg_base=%p conf_addr=%p irq=%d\n",
priv->reg_base, board->conf_addr, dev->irq);
diff --git a/drivers/net/can/usb/ems_usb.c b/drivers/net/can/usb/ems_usb.c
index 00f2534dde73..29d3f0938eb8 100644
--- a/drivers/net/can/usb/ems_usb.c
+++ b/drivers/net/can/usb/ems_usb.c
@@ -434,10 +434,9 @@ static void ems_usb_read_bulk_callback(struct urb *urb)
if (urb->actual_length > CPC_HEADER_SIZE) {
struct ems_cpc_msg *msg;
u8 *ibuf = urb->transfer_buffer;
- u8 msg_count, again, start;
+ u8 msg_count, start;
msg_count = ibuf[0] & ~0x80;
- again = ibuf[0] & 0x80;
start = CPC_HEADER_SIZE;
diff --git a/drivers/net/can/usb/esd_usb2.c b/drivers/net/can/usb/esd_usb2.c
index 7a90075529c3..c063a54ab8dd 100644
--- a/drivers/net/can/usb/esd_usb2.c
+++ b/drivers/net/can/usb/esd_usb2.c
@@ -464,7 +464,6 @@ static void esd_usb2_write_bulk_callback(struct urb *urb)
{
struct esd_tx_urb_context *context = urb->context;
struct esd_usb2_net_priv *priv;
- struct esd_usb2 *dev;
struct net_device *netdev;
size_t size = sizeof(struct esd_usb2_msg);
@@ -472,7 +471,6 @@ static void esd_usb2_write_bulk_callback(struct urb *urb)
priv = context->priv;
netdev = priv->netdev;
- dev = priv->usb2;
/* free up our allocated buffer */
usb_free_coherent(urb->dev, size,
--
2.1.3
next prev parent reply other threads:[~2014-11-18 20:37 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-18 20:37 pull-request: can 2014-11-18 Marc Kleine-Budde
2014-11-18 20:37 ` [PATCH 01/17] can: dev: avoid calling kfree_skb() from interrupt context Marc Kleine-Budde
2014-11-18 20:37 ` [PATCH 02/17] can: dev: fix typo CIA -> CiA, CAN in Automation Marc Kleine-Budde
2014-11-18 20:37 ` [PATCH 03/17] can: dev: add can_is_canfd_skb() API Marc Kleine-Budde
2014-11-18 20:37 ` [PATCH 04/17] can: esd_usb2: fix memory leak on disconnect Marc Kleine-Budde
2014-11-18 20:37 ` Marc Kleine-Budde [this message]
2014-11-18 20:37 ` [PATCH 06/17] can: xilinx_can: fix comparison of unsigned variable Marc Kleine-Budde
2014-11-18 20:37 ` [PATCH 07/17] can: xilinx_can: add .ndo_change_mtu function Marc Kleine-Budde
2014-11-18 20:37 ` [PATCH 08/17] can: rcar_can: " Marc Kleine-Budde
2014-11-18 20:37 ` [PATCH 09/17] can: gs_usb: " Marc Kleine-Budde
2014-11-18 20:37 ` [PATCH 10/17] can: m_can: " Marc Kleine-Budde
2014-11-18 20:37 ` [PATCH 11/17] can: m_can: add CONFIG_HAS_IOMEM dependence Marc Kleine-Budde
2014-11-18 20:37 ` [PATCH 12/17] can: m_can: add missing message RAM initialization Marc Kleine-Budde
2014-11-18 20:37 ` [PATCH 13/17] can: m_can: fix possible sleep in napi poll Marc Kleine-Budde
2014-11-18 20:37 ` [PATCH 14/17] can: m_can: fix not set can_dlc for remote frame Marc Kleine-Budde
2014-11-18 20:37 ` [PATCH 15/17] can: m_can: add missing delay after setting CCCR_INIT bit Marc Kleine-Budde
2014-11-18 20:37 ` [PATCH 16/17] can: m_can: fix incorrect error messages Marc Kleine-Budde
2014-11-18 20:37 ` [PATCH 17/17] can: m_can: update to support CAN FD features Marc Kleine-Budde
2014-11-19 20:29 ` pull-request: can 2014-11-18 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416343067-9810-6-git-send-email-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sudip@vectorindia.org \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox