netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Gavin Shan <gwshan@linux.vnet.ibm.com>
To: netdev@vger.kernel.org
Cc: amirv@mellanox.com, davem@davemloft.net,
	Gavin Shan <gwshan@linux.vnet.ibm.com>
Subject: [PATCH] net/mlx4: Fix EEH recovery failure
Date: Sat, 22 Nov 2014 21:56:47 +1100	[thread overview]
Message-ID: <1416653807-4859-1-git-send-email-gwshan@linux.vnet.ibm.com> (raw)

The patch fixes couple of EEH recovery failures on PPC PowerNV
platform:

   * Release reserved memory regions in mlx4_pci_err_detected().
     Otherwise, __mlx4_init_one() fails because of reserving
     same memory regions recursively.
   * Disable PCI device in mlx4_pci_err_detected(). Otherwise,
     pci_enable_device() in __mlx4_init_one() doesn't enable
     the PCI device because it's already in enabled state indicated
     by struct pci_dev::enable_cnt.
   * Don't clear struct mlx4_priv instance in mlx4_pci_err_detected().
     Otherwise, __mlx4_init_one() runs into kernel crash because
     of dereferencing to NULL pointer.

With the patch applied, EEH recovery for mlx4 adapter succeeds on PPC
PowerNV platform.

   # lspci
   0003:0f:00.0 Network controller: Mellanox Technologies \
   MT27500 Family [ConnectX-3]

Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
---
 drivers/net/ethernet/mellanox/mlx4/main.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/main.c b/drivers/net/ethernet/mellanox/mlx4/main.c
index 90de6e1..e118ac9 100644
--- a/drivers/net/ethernet/mellanox/mlx4/main.c
+++ b/drivers/net/ethernet/mellanox/mlx4/main.c
@@ -2809,7 +2809,6 @@ static void mlx4_unload_one(struct pci_dev *pdev)
 	kfree(dev->caps.qp1_proxy);
 	kfree(dev->dev_vfs);
 
-	memset(priv, 0, sizeof(*priv));
 	priv->pci_dev_data = pci_dev_data;
 	priv->removed = 1;
 }
@@ -2900,6 +2899,8 @@ static pci_ers_result_t mlx4_pci_err_detected(struct pci_dev *pdev,
 					      pci_channel_state_t state)
 {
 	mlx4_unload_one(pdev);
+	pci_release_regions(pdev);
+	pci_disable_device(pdev);
 
 	return state == pci_channel_io_perm_failure ?
 		PCI_ERS_RESULT_DISCONNECT : PCI_ERS_RESULT_NEED_RESET;
-- 
1.8.3.2

             reply	other threads:[~2014-11-22 10:57 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-22 10:56 Gavin Shan [this message]
2014-11-23 16:21 ` [PATCH] net/mlx4: Fix EEH recovery failure Amir Vadai
2014-11-24 21:42   ` Gavin Shan
2014-12-05  4:28 ` Gavin Shan
  -- strict thread matches above, loose matches on Subject: below --
2014-11-24 21:17 Or Gerlitz
2014-11-24 21:55 ` Gavin Shan
2014-11-25 22:00   ` Or Gerlitz
2014-11-25 22:21     ` Gavin Shan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416653807-4859-1-git-send-email-gwshan@linux.vnet.ibm.com \
    --to=gwshan@linux.vnet.ibm.com \
    --cc=amirv@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).