* [patch net-next] tc_vlan: fix type of tcfv_push_vid
@ 2014-11-24 10:30 Jiri Pirko
2014-11-24 13:25 ` Jamal Hadi Salim
2014-11-24 21:12 ` David Miller
0 siblings, 2 replies; 4+ messages in thread
From: Jiri Pirko @ 2014-11-24 10:30 UTC (permalink / raw)
To: netdev; +Cc: davem, jhs
Should be u16. So fix it to kill the sparse warning.
Fixes: c7e2b9689ef8136 "sched: introduce vlan action"
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
include/net/tc_act/tc_vlan.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/tc_act/tc_vlan.h b/include/net/tc_act/tc_vlan.h
index c809c1d..93b70ad 100644
--- a/include/net/tc_act/tc_vlan.h
+++ b/include/net/tc_act/tc_vlan.h
@@ -18,7 +18,7 @@
struct tcf_vlan {
struct tcf_common common;
int tcfv_action;
- __be16 tcfv_push_vid;
+ u16 tcfv_push_vid;
__be16 tcfv_push_proto;
};
#define to_vlan(a) \
--
1.9.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch net-next] tc_vlan: fix type of tcfv_push_vid
2014-11-24 10:30 [patch net-next] tc_vlan: fix type of tcfv_push_vid Jiri Pirko
@ 2014-11-24 13:25 ` Jamal Hadi Salim
2014-11-24 13:33 ` Jiri Pirko
2014-11-24 21:12 ` David Miller
1 sibling, 1 reply; 4+ messages in thread
From: Jamal Hadi Salim @ 2014-11-24 13:25 UTC (permalink / raw)
To: Jiri Pirko, netdev; +Cc: davem
On 11/24/14 05:30, Jiri Pirko wrote:
> Should be u16. So fix it to kill the sparse warning.
>
> Fixes: c7e2b9689ef8136 "sched: introduce vlan action"
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
> ---
> include/net/tc_act/tc_vlan.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/net/tc_act/tc_vlan.h b/include/net/tc_act/tc_vlan.h
> index c809c1d..93b70ad 100644
> --- a/include/net/tc_act/tc_vlan.h
> +++ b/include/net/tc_act/tc_vlan.h
> @@ -18,7 +18,7 @@
> struct tcf_vlan {
> struct tcf_common common;
> int tcfv_action;
> - __be16 tcfv_push_vid;
> + u16 tcfv_push_vid;
> __be16 tcfv_push_proto;
User space sends you this in be, no? I thought it was fine
the way it is. Isnt __be16 just an annotation?
cheers,
jamal
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [patch net-next] tc_vlan: fix type of tcfv_push_vid
2014-11-24 13:25 ` Jamal Hadi Salim
@ 2014-11-24 13:33 ` Jiri Pirko
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Pirko @ 2014-11-24 13:33 UTC (permalink / raw)
To: Jamal Hadi Salim; +Cc: netdev, davem
Mon, Nov 24, 2014 at 02:25:52PM CET, jhs@mojatatu.com wrote:
>On 11/24/14 05:30, Jiri Pirko wrote:
>>Should be u16. So fix it to kill the sparse warning.
>>
>>Fixes: c7e2b9689ef8136 "sched: introduce vlan action"
>>Signed-off-by: Jiri Pirko <jiri@resnulli.us>
>>---
>> include/net/tc_act/tc_vlan.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/include/net/tc_act/tc_vlan.h b/include/net/tc_act/tc_vlan.h
>>index c809c1d..93b70ad 100644
>>--- a/include/net/tc_act/tc_vlan.h
>>+++ b/include/net/tc_act/tc_vlan.h
>>@@ -18,7 +18,7 @@
>> struct tcf_vlan {
>> struct tcf_common common;
>> int tcfv_action;
>>- __be16 tcfv_push_vid;
>>+ u16 tcfv_push_vid;
>> __be16 tcfv_push_proto;
>
>
>User space sends you this in be, no? I thought it was fine
>the way it is. Isnt __be16 just an annotation?
No, userspace sends this in host. Therefore we should store it in host,
not in be. It is just an annotation.
>
>cheers,
>jamal
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [patch net-next] tc_vlan: fix type of tcfv_push_vid
2014-11-24 10:30 [patch net-next] tc_vlan: fix type of tcfv_push_vid Jiri Pirko
2014-11-24 13:25 ` Jamal Hadi Salim
@ 2014-11-24 21:12 ` David Miller
1 sibling, 0 replies; 4+ messages in thread
From: David Miller @ 2014-11-24 21:12 UTC (permalink / raw)
To: jiri; +Cc: netdev, jhs
From: Jiri Pirko <jiri@resnulli.us>
Date: Mon, 24 Nov 2014 11:30:26 +0100
> Should be u16. So fix it to kill the sparse warning.
>
> Fixes: c7e2b9689ef8136 "sched: introduce vlan action"
> Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Applied, thanks Jiri.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-24 21:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-24 10:30 [patch net-next] tc_vlan: fix type of tcfv_push_vid Jiri Pirko
2014-11-24 13:25 ` Jamal Hadi Salim
2014-11-24 13:33 ` Jiri Pirko
2014-11-24 21:12 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).