netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, nhorman@tuxdriver.com, andy@greyhouse.net,
	tgraf@suug.ch, dborkman@redhat.com, ogerlitz@mellanox.com,
	jesse@nicira.com, pshelar@nicira.com, azhou@nicira.com,
	ben@decadent.org.uk, stephen@networkplumber.org,
	jeffrey.t.kirsher@intel.com, vyasevic@redhat.com,
	xiyou.wangcong@gmail.com, john.r.fastabend@intel.com,
	edumazet@google.com, jhs@mojatatu.com, sfeldma@gmail.com,
	f.fainelli@gmail.com, roopa@cumulusnetworks.com,
	linville@tuxdriver.com, jasowang@redhat.com,
	ebiederm@xmission.com, nicolas.dichtel@6wind.com,
	ryazanov.s.a@gmail.com, buytenh@wantstofly.org,
	aviadr@mellanox.com, nbd@openwrt.org,
	alexei.starovoitov@gmail.com, Neil.Jerram@metaswitch.com,
	ronye@mellanox.com, simon.horman@netronome.com,
	alexander.h.duyck@redhat.com, john.ronciak@intel.com,
	mleitner@redhat.com, shrijeet@gmail.com,
	gospo@cumulusnetworks.com, bcrl@kvack.org
Subject: [patch net-next v3 05/17] rtnl: expose physical switch id for particular device
Date: Tue, 25 Nov 2014 11:28:36 +0100	[thread overview]
Message-ID: <1416911328-10979-6-git-send-email-jiri@resnulli.us> (raw)
In-Reply-To: <1416911328-10979-1-git-send-email-jiri@resnulli.us>

The netdevice represents a port in a switch, it will expose
IFLA_PHYS_SWITCH_ID value via rtnl. Two netdevices with the same value
belong to one physical switch.

Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Reviewed-by: Thomas Graf <tgraf@suug.ch>
Acked-by: John Fastabend <john.r.fastabend@intel.com>
---
v2->v3:
-changed "sw" string to "switch" to avoid confusion
v1->v2:
-no change
---
 include/uapi/linux/if_link.h |  1 +
 net/core/rtnetlink.c         | 26 +++++++++++++++++++++++++-
 2 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
index 7072d83..4163753 100644
--- a/include/uapi/linux/if_link.h
+++ b/include/uapi/linux/if_link.h
@@ -145,6 +145,7 @@ enum {
 	IFLA_CARRIER,
 	IFLA_PHYS_PORT_ID,
 	IFLA_CARRIER_CHANGES,
+	IFLA_PHYS_SWITCH_ID,
 	__IFLA_MAX
 };
 
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 0fb3a68..bd5e783 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -44,6 +44,7 @@
 
 #include <linux/inet.h>
 #include <linux/netdevice.h>
+#include <net/switchdev.h>
 #include <net/ip.h>
 #include <net/protocol.h>
 #include <net/arp.h>
@@ -869,7 +870,8 @@ static noinline size_t if_nlmsg_size(const struct net_device *dev,
 	       + rtnl_port_size(dev, ext_filter_mask) /* IFLA_VF_PORTS + IFLA_PORT_SELF */
 	       + rtnl_link_get_size(dev) /* IFLA_LINKINFO */
 	       + rtnl_link_get_af_size(dev) /* IFLA_AF_SPEC */
-	       + nla_total_size(MAX_PHYS_ITEM_ID_LEN); /* IFLA_PHYS_PORT_ID */
+	       + nla_total_size(MAX_PHYS_ITEM_ID_LEN) /* IFLA_PHYS_PORT_ID */
+	       + nla_total_size(MAX_PHYS_ITEM_ID_LEN); /* IFLA_PHYS_SWITCH_ID */
 }
 
 static int rtnl_vf_ports_fill(struct sk_buff *skb, struct net_device *dev)
@@ -968,6 +970,24 @@ static int rtnl_phys_port_id_fill(struct sk_buff *skb, struct net_device *dev)
 	return 0;
 }
 
+static int rtnl_phys_switch_id_fill(struct sk_buff *skb, struct net_device *dev)
+{
+	int err;
+	struct netdev_phys_item_id psid;
+
+	err = netdev_switch_parent_id_get(dev, &psid);
+	if (err) {
+		if (err == -EOPNOTSUPP)
+			return 0;
+		return err;
+	}
+
+	if (nla_put(skb, IFLA_PHYS_SWITCH_ID, psid.id_len, psid.id))
+		return -EMSGSIZE;
+
+	return 0;
+}
+
 static int rtnl_fill_ifinfo(struct sk_buff *skb, struct net_device *dev,
 			    int type, u32 pid, u32 seq, u32 change,
 			    unsigned int flags, u32 ext_filter_mask)
@@ -1040,6 +1060,9 @@ static int rtnl_fill_ifinfo(struct sk_buff *skb, struct net_device *dev,
 	if (rtnl_phys_port_id_fill(skb, dev))
 		goto nla_put_failure;
 
+	if (rtnl_phys_switch_id_fill(skb, dev))
+		goto nla_put_failure;
+
 	attr = nla_reserve(skb, IFLA_STATS,
 			sizeof(struct rtnl_link_stats));
 	if (attr == NULL)
@@ -1199,6 +1222,7 @@ static const struct nla_policy ifla_policy[IFLA_MAX+1] = {
 	[IFLA_NUM_RX_QUEUES]	= { .type = NLA_U32 },
 	[IFLA_PHYS_PORT_ID]	= { .type = NLA_BINARY, .len = MAX_PHYS_ITEM_ID_LEN },
 	[IFLA_CARRIER_CHANGES]	= { .type = NLA_U32 },  /* ignored */
+	[IFLA_PHYS_SWITCH_ID]	= { .type = NLA_BINARY, .len = MAX_PHYS_ITEM_ID_LEN },
 };
 
 static const struct nla_policy ifla_info_policy[IFLA_INFO_MAX+1] = {
-- 
1.9.3

  parent reply	other threads:[~2014-11-25 10:56 UTC|newest]

Thread overview: 148+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-25 10:28 [patch net-next v3 00/17] introduce rocker switch driver with hardware accelerated datapath api - phase 1: bridge fdb offload Jiri Pirko
2014-11-25 10:28 ` [patch net-next v3 01/17] bridge: rename fdb_*_hw to fdb_*_hw_addr to avoid confusion Jiri Pirko
2014-11-25 15:03   ` Andy Gospodarek
2014-11-25 15:26   ` Jamal Hadi Salim
2014-11-25 22:11   ` Thomas Graf
2014-11-25 22:33   ` Florian Fainelli
2014-11-25 10:28 ` [patch net-next v3 02/17] net: make vid as a parameter for ndo_fdb_add/ndo_fdb_del Jiri Pirko
2014-11-25 15:13   ` Andy Gospodarek
2014-11-25 15:18     ` Jiri Pirko
2014-11-25 15:43       ` John Fastabend
2014-11-25 16:38         ` Jiri Pirko
2014-12-09 11:57         ` Or Gerlitz
2014-11-25 15:38   ` Jamal Hadi Salim
2014-11-25 16:01     ` John Fastabend
2014-11-25 16:18       ` Jamal Hadi Salim
2014-11-25 16:30         ` John Fastabend
2014-11-25 16:50           ` Jamal Hadi Salim
2014-11-26  1:44             ` Simon Horman
2014-11-26  2:36             ` Scott Feldman
2014-11-26  3:19               ` Jamal Hadi Salim
2014-11-26  3:59                 ` Scott Feldman
2014-11-26 11:28                   ` Jamal Hadi Salim
2014-11-26 11:40                     ` Jiri Pirko
2014-11-26 11:54                       ` Jamal Hadi Salim
2014-11-26 12:06                         ` Jamal Hadi Salim
2014-11-27  6:50                     ` Scott Feldman
2014-11-27 12:14                       ` Jamal Hadi Salim
2014-11-27 20:59                         ` Scott Feldman
2014-11-27 21:55                           ` Jiri Pirko
2014-11-28 12:57                             ` Jamal Hadi Salim
2014-11-28 10:14               ` Roopa Prabhu
2014-11-28 10:33                 ` Scott Feldman
2014-11-25 16:19     ` Roopa Prabhu
2014-11-25 16:33       ` John Fastabend
2014-11-25 16:57         ` Jamal Hadi Salim
2014-11-25 16:43       ` Jiri Pirko
2014-11-25 18:53   ` Samudrala, Sridhar
2014-11-25 20:40     ` Jiri Pirko
2014-11-25 22:14   ` Thomas Graf
2014-11-25 22:39     ` Florian Fainelli
2014-11-25 23:11       ` Thomas Graf
2014-11-26  7:54     ` Jiri Pirko
2014-11-25 10:28 ` [patch net-next v3 03/17] net: rename netdev_phys_port_id to more generic name Jiri Pirko
2014-11-25 15:15   ` Andy Gospodarek
2014-11-25 15:44   ` Jamal Hadi Salim
2014-11-25 10:28 ` [patch net-next v3 04/17] net: introduce generic switch devices support Jiri Pirko
2014-11-25 15:02   ` Andy Gospodarek
2014-11-25 15:51   ` Jamal Hadi Salim
2014-11-25 16:49     ` Jiri Pirko
2014-11-25 17:08       ` Jamal Hadi Salim
2014-11-25 21:54         ` Thomas Graf
2014-11-26  3:33           ` Jamal Hadi Salim
2014-11-26  4:18             ` Scott Feldman
2014-11-26 11:36               ` Jamal Hadi Salim
2014-11-26 16:08                 ` Thomas Graf
2014-11-26 17:09                   ` Jamal Hadi Salim
2014-11-26 17:59                     ` Jiri Pirko
2014-11-26 21:50                       ` Thomas Graf
2014-11-26 23:32                         ` Jamal Hadi Salim
2014-11-27 13:03                           ` Thomas Graf
2014-11-27 13:32                             ` Jamal Hadi Salim
2014-11-27 13:50                               ` Jiri Pirko
2014-11-28 13:13                                 ` Jamal Hadi Salim
2014-11-27  5:58                 ` Scott Feldman
2014-11-27 12:46                   ` Jamal Hadi Salim
2014-11-27  3:13             ` Simon Horman
2014-11-27 12:35               ` Jamal Hadi Salim
2014-11-25 16:07   ` Roopa Prabhu
2014-11-25 16:50     ` Jiri Pirko
2014-11-25 10:28 ` Jiri Pirko [this message]
2014-11-25 15:16   ` [patch net-next v3 05/17] rtnl: expose physical switch id for particular device Andy Gospodarek
2014-11-25 10:28 ` [patch net-next v3 06/17] net-sysfs: " Jiri Pirko
2014-11-25 15:28   ` Andy Gospodarek
2014-11-25 15:53   ` Jamal Hadi Salim
2014-11-25 22:27   ` Florian Fainelli
2014-11-25 10:28 ` [patch net-next v3 07/17] rocker: introduce rocker switch driver Jiri Pirko
2014-11-25 15:57   ` Jamal Hadi Salim
2014-11-25 16:57     ` Jiri Pirko
2014-11-25 17:10     ` David Miller
2014-11-25 17:15       ` Jiri Pirko
2014-11-25 17:15         ` Jamal Hadi Salim
2014-11-25 17:51         ` Andy Gospodarek
2014-11-25 16:13   ` David Laight
2014-11-25 19:19     ` Scott Feldman
2014-11-25 21:57       ` tgraf
2014-11-25 10:28 ` [patch net-next v3 08/17] bridge: call netdev_sw_port_stp_update when bridge port STP status changes Jiri Pirko
2014-11-25 15:58   ` Andy Gospodarek
2014-11-25 16:53     ` Jiri Pirko
2014-11-25 22:18       ` Thomas Graf
2014-11-25 22:20     ` Florian Fainelli
2014-11-25 22:48   ` Roopa Prabhu
2014-11-26  1:35     ` Scott Feldman
2014-11-28 10:05       ` Roopa Prabhu
2014-11-28 10:51         ` Scott Feldman
2014-11-28 13:17           ` Jamal Hadi Salim
2014-11-28 13:27             ` Jiri Pirko
2014-11-28 16:23             ` Roopa Prabhu
2014-11-25 10:28 ` [patch net-next v3 09/17] bridge: add API to notify bridge driver of learned FBD on offloaded device Jiri Pirko
2014-11-25 16:01   ` Jamal Hadi Salim
2014-11-25 16:38   ` Andy Gospodarek
2014-11-25 22:36     ` Thomas Graf
2014-11-26  1:48       ` Scott Feldman
2014-11-26 10:26         ` Jiri Pirko
2014-11-25 22:44   ` Florian Fainelli
2014-11-26  2:03     ` Scott Feldman
2014-11-26  2:34       ` Florian Fainelli
2014-11-26  2:40         ` Scott Feldman
2014-11-26  8:16           ` Jiri Pirko
2014-11-26  3:22     ` Jamal Hadi Salim
2014-11-25 10:28 ` [patch net-next v3 10/17] rocker: implement rocker ofdpa flow table manipulation Jiri Pirko
2014-11-25 16:03   ` Jamal Hadi Salim
2014-11-25 10:28 ` [patch net-next v3 11/17] rocker: implement L2 bridge offloading Jiri Pirko
2014-11-25 16:04   ` Jamal Hadi Salim
2014-11-25 17:11     ` David Miller
2014-11-25 10:28 ` [patch net-next v3 12/17] rocker: implement ndo_fdb_dump Jiri Pirko
2014-11-25 16:04   ` Jamal Hadi Salim
2014-11-25 10:28 ` [patch net-next v3 13/17] bridge: move private brport flags to if_bridge.h so port drivers can use flags Jiri Pirko
2014-11-25 16:01   ` Andy Gospodarek
2014-11-25 16:05   ` Jamal Hadi Salim
2014-11-25 22:20   ` Florian Fainelli
2014-11-25 22:48   ` Thomas Graf
2014-11-26 12:12     ` Jiri Pirko
2014-11-25 10:28 ` [patch net-next v3 14/17] bridge: add new brport flag LEARNING_SYNC Jiri Pirko
2014-11-25 16:05   ` Roopa Prabhu
2014-11-25 16:06   ` Jamal Hadi Salim
2014-11-25 16:40   ` Andy Gospodarek
2014-11-25 10:28 ` [patch net-next v3 15/17] bridge: add new hwmode swdev Jiri Pirko
2014-11-25 16:03   ` Roopa Prabhu
2014-11-25 16:17     ` Andy Gospodarek
2014-11-25 22:56       ` Thomas Graf
2014-11-25 16:07   ` Jamal Hadi Salim
2014-11-25 23:00     ` Thomas Graf
2014-11-25 10:28 ` [patch net-next v3 16/17] bridge: add brport flags to dflt bridge_getlink Jiri Pirko
2014-11-25 16:08   ` Jamal Hadi Salim
2014-11-25 17:02     ` Scott Feldman
2014-11-25 17:48   ` Andy Gospodarek
2014-11-25 22:07   ` Thomas Graf
2014-11-26  9:25     ` Jiri Pirko
2014-11-26 10:48       ` Thomas Graf
2014-11-25 10:28 ` [patch net-next v3 17/17] rocker: add ndo_bridge_setlnk/getlink support for learning policy Jiri Pirko
2014-11-25 16:09   ` Jamal Hadi Salim
2014-11-25 18:55     ` Scott Feldman
2014-11-25 19:00       ` Jamal Hadi Salim
2014-11-25 20:42         ` Jiri Pirko
2014-11-26 11:07   ` Thomas Graf
2014-11-26 11:27     ` Jiri Pirko
2014-11-26 11:30       ` Thomas Graf
2014-11-26 11:42         ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416911328-10979-6-git-send-email-jiri@resnulli.us \
    --to=jiri@resnulli.us \
    --cc=Neil.Jerram@metaswitch.com \
    --cc=alexander.h.duyck@redhat.com \
    --cc=alexei.starovoitov@gmail.com \
    --cc=andy@greyhouse.net \
    --cc=aviadr@mellanox.com \
    --cc=azhou@nicira.com \
    --cc=bcrl@kvack.org \
    --cc=ben@decadent.org.uk \
    --cc=buytenh@wantstofly.org \
    --cc=davem@davemloft.net \
    --cc=dborkman@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=gospo@cumulusnetworks.com \
    --cc=jasowang@redhat.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse@nicira.com \
    --cc=jhs@mojatatu.com \
    --cc=john.r.fastabend@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=linville@tuxdriver.com \
    --cc=mleitner@redhat.com \
    --cc=nbd@openwrt.org \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=nicolas.dichtel@6wind.com \
    --cc=ogerlitz@mellanox.com \
    --cc=pshelar@nicira.com \
    --cc=ronye@mellanox.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=ryazanov.s.a@gmail.com \
    --cc=sfeldma@gmail.com \
    --cc=shrijeet@gmail.com \
    --cc=simon.horman@netronome.com \
    --cc=stephen@networkplumber.org \
    --cc=tgraf@suug.ch \
    --cc=vyasevic@redhat.com \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).