From: Ying Xue <ying.xue@windriver.com>
To: <davem@davemloft.net>
Cc: <jon.maloy@ericsson.com>, <Paul.Gortmaker@windriver.com>,
<erik.hugne@ericsson.com>, <richard.alpe@ericsson.com>,
<netdev@vger.kernel.org>, <tipc-discussion@lists.sourceforge.net>
Subject: [PATCH net-next 00/11] standardize TIPC SKB queue operations
Date: Wed, 26 Nov 2014 11:41:44 +0800 [thread overview]
Message-ID: <1416973315-6047-1-git-send-email-ying.xue@windriver.com> (raw)
Now the following SKB queues are created and maintained within internal
TIPC stack:
- link transmission queue
- link deferred queue
- link receive queue
- socket outgoing packet chain
- name table outgoing packet chain
In order to manage above queues, TIPC stack declares a sk_buff pointer
for each queue to record its head, and directly modifies "prev" and
"next" SKB pointers of SKB structure when inserting or deleting a SKB
to or from the queue. As these operations are pretty complex, they
easily involve fatal mistakes. If these sk_buff pointers are replaced
with sk_buff_head instances as queue heads and corresponding generic
SKB list APIs are used to manage them, the entire TIPC code would
become quite clean and readable. But before make the change, we need
to clean up below redundant functionalities:
- remove node subscribe infrastructure
- remove protocol message queue
- remove retransmission queue
- clean up process of pushing packets in link layer
Ying Xue (11):
tipc: remove node subscription infrastructure
tipc: remove protocol message queue
tipc: remove retransmission queue
tipc: clean up the process of link pushing packets
tipc: eliminate two pseudo message types of BUNDLE_OPEN and
BUNDLE_CLOSED
tipc: remove unused between routine
tipc: use skb_queue_walk_safe marco to simplify link_prepare_wakeup
routine
tipc: use generic SKB list APIs to manage link transmission queue
tipc: use generic SKB list APIs to manage deferred queue of link
tipc: use generic SKB list APIs to manage link receive queue
tipc: use generic SKB list APIs to manage TIPC outgoing packet chains
net/tipc/Makefile | 4 +-
net/tipc/bcast.c | 109 +++++-----
net/tipc/bcast.h | 2 +-
net/tipc/bearer.h | 2 +-
net/tipc/core.h | 1 +
net/tipc/link.c | 514 ++++++++++++++++++++----------------------------
net/tipc/link.h | 48 ++---
net/tipc/msg.c | 125 ++++++------
net/tipc/msg.h | 16 +-
net/tipc/name_distr.c | 98 ++++++---
net/tipc/name_distr.h | 1 +
net/tipc/name_table.c | 2 +-
net/tipc/name_table.h | 6 +-
net/tipc/node.c | 10 +-
net/tipc/node.h | 12 +-
net/tipc/node_subscr.c | 96 ---------
net/tipc/node_subscr.h | 63 ------
net/tipc/socket.c | 127 ++++++------
18 files changed, 496 insertions(+), 740 deletions(-)
delete mode 100644 net/tipc/node_subscr.c
delete mode 100644 net/tipc/node_subscr.h
--
1.7.9.5
next reply other threads:[~2014-11-26 3:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 3:41 Ying Xue [this message]
2014-11-26 3:41 ` [PATCH net-next 01/11] tipc: remove node subscription infrastructure Ying Xue
2014-11-26 3:41 ` [PATCH net-next 02/11] tipc: remove protocol message queue Ying Xue
2014-11-26 3:41 ` [PATCH net-next 03/11] tipc: remove retransmission queue Ying Xue
2014-11-26 3:41 ` [PATCH net-next 04/11] tipc: clean up the process of link pushing packets Ying Xue
2014-11-26 3:41 ` [PATCH net-next 05/11] tipc: eliminate two pseudo message types of BUNDLE_OPEN and BUNDLE_CLOSED Ying Xue
2014-11-26 3:41 ` [PATCH net-next 06/11] tipc: remove unused between routine Ying Xue
2014-11-26 3:41 ` [PATCH net-next 07/11] tipc: use skb_queue_walk_safe marco to simplify link_prepare_wakeup routine Ying Xue
2014-11-26 3:41 ` [PATCH net-next 08/11] tipc: use generic SKB list APIs to manage link transmission queue Ying Xue
2014-11-26 3:41 ` [PATCH net-next 09/11] tipc: use generic SKB list APIs to manage deferred queue of link Ying Xue
2014-11-26 3:41 ` [PATCH net-next 10/11] tipc: use generic SKB list APIs to manage link receive queue Ying Xue
2014-11-26 3:41 ` [PATCH net-next 11/11] tipc: use generic SKB list APIs to manage TIPC outgoing packet chains Ying Xue
2014-11-26 17:31 ` [PATCH net-next 00/11] standardize TIPC SKB queue operations David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416973315-6047-1-git-send-email-ying.xue@windriver.com \
--to=ying.xue@windriver.com \
--cc=Paul.Gortmaker@windriver.com \
--cc=davem@davemloft.net \
--cc=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=richard.alpe@ericsson.com \
--cc=tipc-discussion@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).