From: Jason Wang <jasowang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
mst@redhat.com, eric.dumazet@gmail.com
Subject: Re: [PATCH net-next V3] tun/macvtap: use consume_skb() instead of kfree_skb() when needed
Date: Mon, 01 Dec 2014 05:43:15 +0008 [thread overview]
Message-ID: <1417412115.7521.2@smtp.corp.redhat.com> (raw)
In-Reply-To: <20141129.210350.1994537005887744173.davem@davemloft.net>
On Sun, Nov 30, 2014 at 1:03 PM, David Miller <davem@davemloft.net>
wrote:
> From: Jason Wang <jasowang@redhat.com>
> Date: Thu, 27 Nov 2014 14:36:06 +0800
>
>> To be more friendly with drop monitor, we should only call
>> kfree_skb() when
>> the packets were dropped and use consume_skb() in other cases.
>>
>> Cc: Eric Dumazet <eric.dumazet@gmail.com>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>> ---
>> Changes from V2:
>> - use unlikely() when necessary
>> Changes from V1:
>> - check the return value of tun/macvtap_put_user()
>
> This does not apply cleanly to net-next and will thus need to
> be respun, thanks.
Will post V3.
Thanks
prev parent reply other threads:[~2014-12-01 5:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 6:36 [PATCH net-next V3] tun/macvtap: use consume_skb() instead of kfree_skb() when needed Jason Wang
2014-11-30 5:03 ` David Miller
2014-12-01 5:35 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417412115.7521.2@smtp.corp.redhat.com \
--to=jasowang@redhat.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).