From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, jhs@mojatatu.com
Subject: [patch net-next 1/6] net_sched: cls_basic: remove unnecessary iteration and use passed arg
Date: Tue, 2 Dec 2014 18:00:31 +0100 [thread overview]
Message-ID: <1417539636-12710-2-git-send-email-jiri@resnulli.us> (raw)
In-Reply-To: <1417539636-12710-1-git-send-email-jiri@resnulli.us>
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
---
net/sched/cls_basic.c | 16 +++++-----------
1 file changed, 5 insertions(+), 11 deletions(-)
diff --git a/net/sched/cls_basic.c b/net/sched/cls_basic.c
index cd61280..1c122c7 100644
--- a/net/sched/cls_basic.c
+++ b/net/sched/cls_basic.c
@@ -113,18 +113,12 @@ static void basic_destroy(struct tcf_proto *tp)
static int basic_delete(struct tcf_proto *tp, unsigned long arg)
{
- struct basic_head *head = rtnl_dereference(tp->root);
- struct basic_filter *t, *f = (struct basic_filter *) arg;
-
- list_for_each_entry(t, &head->flist, link)
- if (t == f) {
- list_del_rcu(&t->link);
- tcf_unbind_filter(tp, &t->res);
- call_rcu(&t->rcu, basic_delete_filter);
- return 0;
- }
+ struct basic_filter *f = (struct basic_filter *) arg;
- return -ENOENT;
+ list_del_rcu(&f->link);
+ tcf_unbind_filter(tp, &f->res);
+ call_rcu(&f->rcu, basic_delete_filter);
+ return 0;
}
static const struct nla_policy basic_policy[TCA_BASIC_MAX + 1] = {
--
1.9.3
next prev parent reply other threads:[~2014-12-02 17:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 17:00 [patch net-next 0/6] net_sched: cls_*: couple of fixes Jiri Pirko
2014-12-02 17:00 ` Jiri Pirko [this message]
2014-12-03 12:45 ` [patch net-next 1/6] net_sched: cls_basic: remove unnecessary iteration and use passed arg Jamal Hadi Salim
2014-12-02 17:00 ` [patch net-next 2/6] net_sched: cls_bpf: " Jiri Pirko
2014-12-03 12:46 ` Jamal Hadi Salim
2014-12-03 13:38 ` Daniel Borkmann
2014-12-02 17:00 ` [patch net-next 3/6] net_sched: cls_bpf: remove faulty use of list_for_each_entry_rcu Jiri Pirko
2014-12-03 12:19 ` Pablo Neira Ayuso
2014-12-03 13:21 ` Jiri Pirko
2014-12-03 13:50 ` Pablo Neira Ayuso
2014-12-03 12:51 ` Jamal Hadi Salim
2014-12-03 13:26 ` Jiri Pirko
2014-12-03 14:37 ` Jamal Hadi Salim
2014-12-03 15:20 ` Jiri Pirko
2014-12-03 21:15 ` Jamal Hadi Salim
2014-12-03 23:15 ` Daniel Borkmann
2014-12-02 17:00 ` [patch net-next 4/6] net_sched: cls_flow: " Jiri Pirko
2014-12-03 13:02 ` Jamal Hadi Salim
2014-12-02 17:00 ` [patch net-next 5/6] net_sched: cls_flow: remove duplicate assignments Jiri Pirko
2014-12-02 17:00 ` [patch net-next 6/6] net_sched: cls_cgroup: remove unnecessary if Jiri Pirko
2014-12-03 13:07 ` Jamal Hadi Salim
2014-12-03 13:18 ` Jiri Pirko
2014-12-03 14:30 ` Jamal Hadi Salim
2014-12-03 14:39 ` Jiri Pirko
2014-12-03 13:50 ` [patch net-next 0/6] net_sched: cls_*: couple of fixes Thomas Graf
2014-12-09 1:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417539636-12710-2-git-send-email-jiri@resnulli.us \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).