From: Jason Wang <jasowang@redhat.com>
To: Valdis Kletnieks <Valdis.Kletnieks@vt.edu>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: linux-next Problems with VPN tunnel - no packets sent
Date: Wed, 03 Dec 2014 03:20:19 +0008 [thread overview]
Message-ID: <1417576339.19959.0@smtp.corp.redhat.com> (raw)
In-Reply-To: <17929.1417552899@turing-police.cc.vt.edu>
On Wed, Dec 3, 2014 at 4:41 AM, Valdis Kletnieks
<Valdis.Kletnieks@vt.edu> wrote:
> Recent linux-next has broken my Juniper VPN client. The tunnel gets
> created,
> routes get added, but trying to actually send packets across results
> in packets
> just disappearing. 'ifconfig' consistently reports exactly 1 packet
> sent (even
> after a 'ping' command or similar should have sent multiple packets.
>
> tun0: flags=4305<UP,POINTOPOINT,RUNNING,NOARP,MULTICAST> mtu 1400
> inet 172.27.1.40 netmask 255.255.255.255 destination
> 172.27.1.40
> unspec 00-00-00-00-00-00-00-00-00-00-00-00-00-00-00-00
> txqueuelen 500 (UNSPEC)
> RX packets 1 bytes 355 (355.0 B)
> RX errors 0 dropped 0 overruns 0 frame 0
> TX packets 1 bytes 61 (61.0 B)
> TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0
>
> Still broken in next-20141201, and bisection fingers this commit:
>
> commit e0b46d0ee9c240c7430a47e9b0365674d4a04522
> Author: Herbert Xu <herbert@gondor.apana.org.au>
> Date: Fri Nov 7 21:22:23 2014 +0800
>
> tun: Use iovec iterators
>
> This patch removes the use of skb_copy_datagram_const_iovec in
> favour of the iovec iterator-based skb_copy_datagram_iter.
>
> This commit is in the kernel, and does *not* fix the problem:
>
> commit 8c847d254146d32c86574a1b16923ff91bb784dd
> Author: Jason Wang <jasowang@redhat.com>
> Date: Thu Nov 13 16:54:14 2014 +0800
>
> tun: fix issues of iovec iterators using in tun_put_user()
>
> So there's apparently additional issues that Jason didn't address. I
> tried to
> revert Herbert's patch for testing, but there's at least 5 or 6
> other patches
> that need reverting first, so I abandoned that unless it becomes
> necessary...
>
> What's the best way to proceed?
See another fixes from Herbert, it probably fixes your issue:
http://marc.info/?l=linux-netdev&m=141734182302021&w=2
next prev parent reply other threads:[~2014-12-03 3:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 20:41 linux-next Problems with VPN tunnel - no packets sent Valdis Kletnieks
2014-12-03 3:12 ` Jason Wang [this message]
2014-12-03 14:51 ` Valdis.Kletnieks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417576339.19959.0@smtp.corp.redhat.com \
--to=jasowang@redhat.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).