* linux-next Problems with VPN tunnel - no packets sent
@ 2014-12-02 20:41 Valdis Kletnieks
2014-12-03 3:12 ` Jason Wang
0 siblings, 1 reply; 3+ messages in thread
From: Valdis Kletnieks @ 2014-12-02 20:41 UTC (permalink / raw)
To: Herbert Xu, davem, Jason Wang; +Cc: netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1628 bytes --]
Recent linux-next has broken my Juniper VPN client. The tunnel gets created,
routes get added, but trying to actually send packets across results in packets
just disappearing. 'ifconfig' consistently reports exactly 1 packet sent (even
after a 'ping' command or similar should have sent multiple packets.
tun0: flags=4305<UP,POINTOPOINT,RUNNING,NOARP,MULTICAST> mtu 1400
inet 172.27.1.40 netmask 255.255.255.255 destination 172.27.1.40
unspec 00-00-00-00-00-00-00-00-00-00-00-00-00-00-00-00 txqueuelen 500 (UNSPEC)
RX packets 1 bytes 355 (355.0 B)
RX errors 0 dropped 0 overruns 0 frame 0
TX packets 1 bytes 61 (61.0 B)
TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0
Still broken in next-20141201, and bisection fingers this commit:
commit e0b46d0ee9c240c7430a47e9b0365674d4a04522
Author: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri Nov 7 21:22:23 2014 +0800
tun: Use iovec iterators
This patch removes the use of skb_copy_datagram_const_iovec in
favour of the iovec iterator-based skb_copy_datagram_iter.
This commit is in the kernel, and does *not* fix the problem:
commit 8c847d254146d32c86574a1b16923ff91bb784dd
Author: Jason Wang <jasowang@redhat.com>
Date: Thu Nov 13 16:54:14 2014 +0800
tun: fix issues of iovec iterators using in tun_put_user()
So there's apparently additional issues that Jason didn't address. I tried to
revert Herbert's patch for testing, but there's at least 5 or 6 other patches
that need reverting first, so I abandoned that unless it becomes necessary...
What's the best way to proceed?
[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next Problems with VPN tunnel - no packets sent
2014-12-02 20:41 linux-next Problems with VPN tunnel - no packets sent Valdis Kletnieks
@ 2014-12-03 3:12 ` Jason Wang
2014-12-03 14:51 ` Valdis.Kletnieks
0 siblings, 1 reply; 3+ messages in thread
From: Jason Wang @ 2014-12-03 3:12 UTC (permalink / raw)
To: Valdis Kletnieks; +Cc: Herbert Xu, davem, netdev, linux-kernel
On Wed, Dec 3, 2014 at 4:41 AM, Valdis Kletnieks
<Valdis.Kletnieks@vt.edu> wrote:
> Recent linux-next has broken my Juniper VPN client. The tunnel gets
> created,
> routes get added, but trying to actually send packets across results
> in packets
> just disappearing. 'ifconfig' consistently reports exactly 1 packet
> sent (even
> after a 'ping' command or similar should have sent multiple packets.
>
> tun0: flags=4305<UP,POINTOPOINT,RUNNING,NOARP,MULTICAST> mtu 1400
> inet 172.27.1.40 netmask 255.255.255.255 destination
> 172.27.1.40
> unspec 00-00-00-00-00-00-00-00-00-00-00-00-00-00-00-00
> txqueuelen 500 (UNSPEC)
> RX packets 1 bytes 355 (355.0 B)
> RX errors 0 dropped 0 overruns 0 frame 0
> TX packets 1 bytes 61 (61.0 B)
> TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0
>
> Still broken in next-20141201, and bisection fingers this commit:
>
> commit e0b46d0ee9c240c7430a47e9b0365674d4a04522
> Author: Herbert Xu <herbert@gondor.apana.org.au>
> Date: Fri Nov 7 21:22:23 2014 +0800
>
> tun: Use iovec iterators
>
> This patch removes the use of skb_copy_datagram_const_iovec in
> favour of the iovec iterator-based skb_copy_datagram_iter.
>
> This commit is in the kernel, and does *not* fix the problem:
>
> commit 8c847d254146d32c86574a1b16923ff91bb784dd
> Author: Jason Wang <jasowang@redhat.com>
> Date: Thu Nov 13 16:54:14 2014 +0800
>
> tun: fix issues of iovec iterators using in tun_put_user()
>
> So there's apparently additional issues that Jason didn't address. I
> tried to
> revert Herbert's patch for testing, but there's at least 5 or 6
> other patches
> that need reverting first, so I abandoned that unless it becomes
> necessary...
>
> What's the best way to proceed?
See another fixes from Herbert, it probably fixes your issue:
http://marc.info/?l=linux-netdev&m=141734182302021&w=2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next Problems with VPN tunnel - no packets sent
2014-12-03 3:12 ` Jason Wang
@ 2014-12-03 14:51 ` Valdis.Kletnieks
0 siblings, 0 replies; 3+ messages in thread
From: Valdis.Kletnieks @ 2014-12-03 14:51 UTC (permalink / raw)
To: Jason Wang; +Cc: Herbert Xu, davem, netdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 571 bytes --]
On Wed, 03 Dec 2014 03:20:19 +0008, Jason Wang said:
> > Still broken in next-20141201, and bisection fingers this commit:
> >
> > commit e0b46d0ee9c240c7430a47e9b0365674d4a04522
> > Author: Herbert Xu <herbert@gondor.apana.org.au>
> > Date: Fri Nov 7 21:22:23 2014 +0800
> >
> > tun: Use iovec iterators
> > What's the best way to proceed?
>
> See another fixes from Herbert, it probably fixes your issue:
>
> http://marc.info/?l=linux-netdev&m=141734182302021&w=2
Unfortunately, I'm still seeing the same behavior with that patch
applied to next-20141201....
[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-03 14:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-02 20:41 linux-next Problems with VPN tunnel - no packets sent Valdis Kletnieks
2014-12-03 3:12 ` Jason Wang
2014-12-03 14:51 ` Valdis.Kletnieks
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).