* CAN presume-ack feature [not found] <1417766390-4587-1-git-send-email-nebaruzdin@gmail.com> @ 2014-12-05 8:41 ` Nikita Edward Baruzdin 2014-12-05 8:41 ` [PATCH] iproute2: Add support for " Nikita Edward Baruzdin 0 siblings, 1 reply; 4+ messages in thread From: Nikita Edward Baruzdin @ 2014-12-05 8:41 UTC (permalink / raw) To: linux-can, netdev Hello, all. I just remembered about this small patch I promised to submit. It corresponds to an earlier introduced change in SocketCAN subsystem, see http://thread.gmane.org/gmane.linux.can/6110 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] iproute2: Add support for CAN presume-ack feature 2014-12-05 8:41 ` CAN presume-ack feature Nikita Edward Baruzdin @ 2014-12-05 8:41 ` Nikita Edward Baruzdin 2014-12-06 10:33 ` Oliver Hartkopp 2014-12-10 4:35 ` Stephen Hemminger 0 siblings, 2 replies; 4+ messages in thread From: Nikita Edward Baruzdin @ 2014-12-05 8:41 UTC (permalink / raw) To: linux-can, netdev This patch makes CAN_CTRLMODE_PRESUME_ACK netlink feature configurable. When enabled, the feature sets CAN controller in mode in which acknowledgement absence is ignored. Signed-off-by: Nikita Edward Baruzdin <nebaruzdin@gmail.com> --- ip/iplink_can.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/ip/iplink_can.c b/ip/iplink_can.c index 5b92426..fb50332 100644 --- a/ip/iplink_can.c +++ b/ip/iplink_can.c @@ -37,6 +37,7 @@ static void print_usage(FILE *f) "\t[ one-shot { on | off } ]\n" "\t[ berr-reporting { on | off } ]\n" "\t[ fd { on | off } ]\n" + "\t[ presume-ack { on | off } ]\n" "\n" "\t[ restart-ms TIME-MS ]\n" "\t[ restart ]\n" @@ -99,6 +100,7 @@ static void print_ctrlmode(FILE *f, __u32 cm) _PF(CAN_CTRLMODE_ONE_SHOT, "ONE-SHOT"); _PF(CAN_CTRLMODE_BERR_REPORTING, "BERR-REPORTING"); _PF(CAN_CTRLMODE_FD, "FD"); + _PF(CAN_CTRLMODE_PRESUME_ACK, "PRESUME-ACK"); #undef _PF if (cm) fprintf(f, "%x", cm); @@ -201,6 +203,10 @@ static int can_parse_opt(struct link_util *lu, int argc, char **argv, NEXT_ARG(); set_ctrlmode("fd", *argv, &cm, CAN_CTRLMODE_FD); + } else if (matches(*argv, "presume-ack") == 0) { + NEXT_ARG(); + set_ctrlmode("presume-ack", *argv, &cm, + CAN_CTRLMODE_PRESUME_ACK); } else if (matches(*argv, "restart") == 0) { __u32 val = 1; -- 2.1.3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iproute2: Add support for CAN presume-ack feature 2014-12-05 8:41 ` [PATCH] iproute2: Add support for " Nikita Edward Baruzdin @ 2014-12-06 10:33 ` Oliver Hartkopp 2014-12-10 4:35 ` Stephen Hemminger 1 sibling, 0 replies; 4+ messages in thread From: Oliver Hartkopp @ 2014-12-06 10:33 UTC (permalink / raw) To: Nikita Edward Baruzdin, linux-can, netdev On 05.12.2014 09:41, Nikita Edward Baruzdin wrote: > This patch makes CAN_CTRLMODE_PRESUME_ACK netlink feature configurable. > When enabled, the feature sets CAN controller in mode in which > acknowledgement absence is ignored. > > Signed-off-by: Nikita Edward Baruzdin <nebaruzdin@gmail.com> Acked-by: Oliver Hartkopp <socketcan@hartkopp.net> Hi Nikita, I just noticed that you only posted to linux-can ML last time - so it didn't reach the iproute and netdev guys like Stephen Hemminger ... Thanks for posting it again to the appropriate MLs. Best regards, Oliver > --- > ip/iplink_can.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/ip/iplink_can.c b/ip/iplink_can.c > index 5b92426..fb50332 100644 > --- a/ip/iplink_can.c > +++ b/ip/iplink_can.c > @@ -37,6 +37,7 @@ static void print_usage(FILE *f) > "\t[ one-shot { on | off } ]\n" > "\t[ berr-reporting { on | off } ]\n" > "\t[ fd { on | off } ]\n" > + "\t[ presume-ack { on | off } ]\n" > "\n" > "\t[ restart-ms TIME-MS ]\n" > "\t[ restart ]\n" > @@ -99,6 +100,7 @@ static void print_ctrlmode(FILE *f, __u32 cm) > _PF(CAN_CTRLMODE_ONE_SHOT, "ONE-SHOT"); > _PF(CAN_CTRLMODE_BERR_REPORTING, "BERR-REPORTING"); > _PF(CAN_CTRLMODE_FD, "FD"); > + _PF(CAN_CTRLMODE_PRESUME_ACK, "PRESUME-ACK"); > #undef _PF > if (cm) > fprintf(f, "%x", cm); > @@ -201,6 +203,10 @@ static int can_parse_opt(struct link_util *lu, int argc, char **argv, > NEXT_ARG(); > set_ctrlmode("fd", *argv, &cm, > CAN_CTRLMODE_FD); > + } else if (matches(*argv, "presume-ack") == 0) { > + NEXT_ARG(); > + set_ctrlmode("presume-ack", *argv, &cm, > + CAN_CTRLMODE_PRESUME_ACK); > } else if (matches(*argv, "restart") == 0) { > __u32 val = 1; > > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iproute2: Add support for CAN presume-ack feature 2014-12-05 8:41 ` [PATCH] iproute2: Add support for " Nikita Edward Baruzdin 2014-12-06 10:33 ` Oliver Hartkopp @ 2014-12-10 4:35 ` Stephen Hemminger 1 sibling, 0 replies; 4+ messages in thread From: Stephen Hemminger @ 2014-12-10 4:35 UTC (permalink / raw) To: Nikita Edward Baruzdin; +Cc: linux-can, netdev On Fri, 5 Dec 2014 11:41:42 +0300 Nikita Edward Baruzdin <nebaruzdin@gmail.com> wrote: > This patch makes CAN_CTRLMODE_PRESUME_ACK netlink feature configurable. > When enabled, the feature sets CAN controller in mode in which > acknowledgement absence is ignored. > > Signed-off-by: Nikita Edward Baruzdin <nebaruzdin@gmail.com> > --- Applied. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-12-10 4:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1417766390-4587-1-git-send-email-nebaruzdin@gmail.com>
2014-12-05 8:41 ` CAN presume-ack feature Nikita Edward Baruzdin
2014-12-05 8:41 ` [PATCH] iproute2: Add support for " Nikita Edward Baruzdin
2014-12-06 10:33 ` Oliver Hartkopp
2014-12-10 4:35 ` Stephen Hemminger
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).