From: Andy Gospodarek <gospo@cumulusnetworks.com>
To: netdev@vger.kernel.org
Cc: sfeldma@gmail.com, jpirko@resnulli.us
Subject: [PATCH net-next 2/3] netlink: IFLA_PHYS_SWITCH_ID to IFLA_PHYS_PARENT_ID
Date: Fri, 5 Dec 2014 13:02:16 -0500 [thread overview]
Message-ID: <1417802537-20020-2-git-send-email-gospo@cumulusnetworks.com> (raw)
In-Reply-To: <1417802537-20020-1-git-send-email-gospo@cumulusnetworks.com>
There has been much discussion about proper nomenclature to use for this
and I would prefer parent rather than calling every forwarding element a
switch.
Signed-off-by: Andy Gospodarek <gospo@cumulusnetworks.com>
---
include/uapi/linux/if_link.h | 2 +-
net/core/rtnetlink.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
index f7d0d2d..3d8edd8 100644
--- a/include/uapi/linux/if_link.h
+++ b/include/uapi/linux/if_link.h
@@ -145,7 +145,7 @@ enum {
IFLA_CARRIER,
IFLA_PHYS_PORT_ID,
IFLA_CARRIER_CHANGES,
- IFLA_PHYS_SWITCH_ID,
+ IFLA_PHYS_PARENT_ID,
__IFLA_MAX
};
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c
index 61cb7e7..1fe0a16 100644
--- a/net/core/rtnetlink.c
+++ b/net/core/rtnetlink.c
@@ -982,7 +982,7 @@ static int rtnl_phys_switch_id_fill(struct sk_buff *skb, struct net_device *dev)
return err;
}
- if (nla_put(skb, IFLA_PHYS_SWITCH_ID, psid.id_len, psid.id))
+ if (nla_put(skb, IFLA_PHYS_PARENT_ID, psid.id_len, psid.id))
return -EMSGSIZE;
return 0;
@@ -1222,7 +1222,7 @@ static const struct nla_policy ifla_policy[IFLA_MAX+1] = {
[IFLA_NUM_RX_QUEUES] = { .type = NLA_U32 },
[IFLA_PHYS_PORT_ID] = { .type = NLA_BINARY, .len = MAX_PHYS_ITEM_ID_LEN },
[IFLA_CARRIER_CHANGES] = { .type = NLA_U32 }, /* ignored */
- [IFLA_PHYS_SWITCH_ID] = { .type = NLA_BINARY, .len = MAX_PHYS_ITEM_ID_LEN },
+ [IFLA_PHYS_PARENT_ID] = { .type = NLA_BINARY, .len = MAX_PHYS_ITEM_ID_LEN },
};
static const struct nla_policy ifla_info_policy[IFLA_INFO_MAX+1] = {
--
1.9.3
next prev parent reply other threads:[~2014-12-05 18:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 18:02 [PATCH iproute2 1/3] ip-link: display parentid for netdevs Andy Gospodarek
2014-12-05 18:02 ` Andy Gospodarek [this message]
2014-12-08 15:17 ` [PATCH net-next 2/3] netlink: IFLA_PHYS_SWITCH_ID to IFLA_PHYS_PARENT_ID Jiri Pirko
2014-12-08 15:37 ` Andy Gospodarek
2014-12-08 16:41 ` Jiri Pirko
2014-12-08 17:49 ` Andy Gospodarek
2014-12-05 18:02 ` [PATCH net-next 3/3] net: rename *_switch_parent_id_get to *_parent_id_get Andy Gospodarek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417802537-20020-2-git-send-email-gospo@cumulusnetworks.com \
--to=gospo@cumulusnetworks.com \
--cc=jpirko@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox