Re: [net-next 04/14] ixgbe: remove CIAA/D register reads from bad VF check

[Jeff Kirsher <jeffrey.t.kirsher@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

On Fri, 2014-12-05 at 20:49 -0800, David Miller wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Date: Fri,  5 Dec 2014 09:52:43 -0800
> 
> > From: Emil Tantilov <emil.s.tantilov@intel.com>
> > 
> > Accessing the CIAA/D register can block access to the PCI config space.
> > 
> > This patch removes the read/write operations to the CIAA/D registers
> > and makes use of standard kernel functions for accessing the PCI config
> > space.
> > 
> > In addition it moves ixgbevf_check_for_bad_vf() into the watchdog subtask
> > which reduces the frequency of the checks.
> > 
> > CC: Alex Williamson <alex.williamson@redhat.com>
> > Reported-by: Alex Williamson <alex.williamson@redhat.com>
> > Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
> > Tested-by: Aaron Brown <aaron.f.brown@intel.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> 
> Alex Willaimson stated that he'd like to see this for -stable, but I'm warning
> right now that a change not appropriate for 'net' is not approperiate for
> '-stable' either.

Agreed, only reason I did not send this to net (along with the other
fixes by Emil) was that we are at -rc7 and do not consider these
"critical" to try and squeeze in before the release.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]