* [PATCH net-next 4/4] macvlan: play well with ipvlan device
@ 2014-12-06 23:53 Mahesh Bandewar
2014-12-09 21:10 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Mahesh Bandewar @ 2014-12-06 23:53 UTC (permalink / raw)
To: netdev; +Cc: David Miller, Eric Dumazet, Mahesh Bandewar
If device is already used as an ipvlan port then refuse to
use it as a macvlan port at early stage of port creation.
thost1:~# ip link add link eth0 ipvl0 type ipvlan
thost1:~# echo $?
0
thost1:~# ip link add link eth0 mvl0 type macvlan
RTNETLINK answers: Device or resource busy
thost1:~# echo $?
2
thost1:~#
Signed-off-by: Mahesh Bandewar <maheshb@google.com>
---
drivers/net/macvlan.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index 9538674587aa..84b4008210c7 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -1056,6 +1056,9 @@ static int macvlan_port_create(struct net_device *dev)
if (dev->type != ARPHRD_ETHER || dev->flags & IFF_LOOPBACK)
return -EINVAL;
+ if (netif_is_ipvlan_port(dev))
+ return -EBUSY;
+
port = kzalloc(sizeof(*port), GFP_KERNEL);
if (port == NULL)
return -ENOMEM;
--
2.2.0.rc0.207.ga3a616c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next 4/4] macvlan: play well with ipvlan device
2014-12-06 23:53 [PATCH net-next 4/4] macvlan: play well with ipvlan device Mahesh Bandewar
@ 2014-12-09 21:10 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-12-09 21:10 UTC (permalink / raw)
To: maheshb; +Cc: netdev, edumazet
From: Mahesh Bandewar <maheshb@google.com>
Date: Sat, 6 Dec 2014 15:53:46 -0800
> If device is already used as an ipvlan port then refuse to
> use it as a macvlan port at early stage of port creation.
>
> thost1:~# ip link add link eth0 ipvl0 type ipvlan
> thost1:~# echo $?
> 0
> thost1:~# ip link add link eth0 mvl0 type macvlan
> RTNETLINK answers: Device or resource busy
> thost1:~# echo $?
> 2
> thost1:~#
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-09 21:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-06 23:53 [PATCH net-next 4/4] macvlan: play well with ipvlan device Mahesh Bandewar
2014-12-09 21:10 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).