From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Joe Perches <joe@perches.com>
Cc: kbuild@01.org, Shannon Nelson <shannon.nelson@intel.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
netdev <netdev@vger.kernel.org>,
nhorman@redhat.com, sassmann@redhat.com, jogreene@redhat.com
Subject: Re: [PATCH] i40e: Fix possible memory leak in i40e_dbg_dump_desc
Date: Sun, 07 Dec 2014 11:57:32 -0800 [thread overview]
Message-ID: <1417982252.2399.51.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1417874601.31745.21.camel@perches.com>
[-- Attachment #1: Type: text/plain, Size: 692 bytes --]
On Sat, 2014-12-06 at 06:03 -0800, Joe Perches wrote:
> I didn't notice that return in the code, fix it by
> adding a goto out instead to free the memory.
>
> Fixes:
>
> > New smatch warnings:
> > drivers/net/ethernet/intel/i40e/i40e_debugfs.c:832
> i40e_dbg_dump_desc() warn: possible memory leak of 'ring'
>
> Signed-off-by: Joe Perches <joe@perches.com>
> Noticed-by: Dan Carpenter <dan.carpenter@oracle.com> (go smatch)
> ---
>
> Jeff Kirsher can legitimately give me a hard time now...
> Thanks Dan.
>
> drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Thanks Joe, I have added your patch to my queue.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2014-12-07 19:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20141206134513.GD4963@mwanda>
2014-12-06 14:03 ` [PATCH] i40e: Fix possible memory leak in i40e_dbg_dump_desc Joe Perches
2014-12-07 19:57 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417982252.2399.51.camel@jtkirshe-mobl \
--to=jeffrey.t.kirsher@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=joe@perches.com \
--cc=jogreene@redhat.com \
--cc=kbuild@01.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
--cc=shannon.nelson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).