* [PATCH][net-next][V2] net: avoid to call skb_queue_len again
@ 2014-12-08 1:42 roy.qing.li
2014-12-09 22:03 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: roy.qing.li @ 2014-12-08 1:42 UTC (permalink / raw)
To: netdev; +Cc: edumazet, sergei.shtylyov
From: Li RongQing <roy.qing.li@gmail.com>
the queue length of sd->input_pkt_queue has been put into qlen,
and impossible to change, since hold the lock
Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
---
net/core/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/core/dev.c b/net/core/dev.c
index 0814a56..b954400 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -3297,7 +3297,7 @@ static int enqueue_to_backlog(struct sk_buff *skb, int cpu,
rps_lock(sd);
qlen = skb_queue_len(&sd->input_pkt_queue);
if (qlen <= netdev_max_backlog && !skb_flow_limit(skb, qlen)) {
- if (skb_queue_len(&sd->input_pkt_queue)) {
+ if (qlen) {
enqueue:
__skb_queue_tail(&sd->input_pkt_queue, skb);
input_queue_tail_incr_save(sd, qtail);
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][net-next][V2] net: avoid to call skb_queue_len again
2014-12-08 1:42 [PATCH][net-next][V2] net: avoid to call skb_queue_len again roy.qing.li
@ 2014-12-09 22:03 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-12-09 22:03 UTC (permalink / raw)
To: roy.qing.li; +Cc: netdev, edumazet, sergei.shtylyov
From: roy.qing.li@gmail.com
Date: Mon, 8 Dec 2014 09:42:55 +0800
> From: Li RongQing <roy.qing.li@gmail.com>
>
> the queue length of sd->input_pkt_queue has been put into qlen,
> and impossible to change, since hold the lock
>
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
> Acked-by: Eric Dumazet <edumazet@google.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-09 22:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-08 1:42 [PATCH][net-next][V2] net: avoid to call skb_queue_len again roy.qing.li
2014-12-09 22:03 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).