* [PATCH] netback: don't store invalid vif pointer
@ 2014-12-09 11:47 Jan Beulich
2014-12-09 12:08 ` Ian Campbell
2014-12-09 23:30 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2014-12-09 11:47 UTC (permalink / raw)
To: Wei Liu, Ian Campbell; +Cc: xen-devel, netdev
When xenvif_alloc() fails, it returns a non-NULL error indicator. To
avoid eventual races, we shouldn't store that into struct backend_info
as readers of it only check for NULL.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/drivers/net/xen-netback/xenbus.c
+++ b/drivers/net/xen-netback/xenbus.c
@@ -404,6 +404,7 @@ static int backend_create_xenvif(struct
int err;
long handle;
struct xenbus_device *dev = be->dev;
+ struct xenvif *vif;
if (be->vif != NULL)
return 0;
@@ -414,13 +415,13 @@ static int backend_create_xenvif(struct
return (err < 0) ? err : -EINVAL;
}
- be->vif = xenvif_alloc(&dev->dev, dev->otherend_id, handle);
- if (IS_ERR(be->vif)) {
- err = PTR_ERR(be->vif);
- be->vif = NULL;
+ vif = xenvif_alloc(&dev->dev, dev->otherend_id, handle);
+ if (IS_ERR(vif)) {
+ err = PTR_ERR(vif);
xenbus_dev_fatal(dev, err, "creating interface");
return err;
}
+ be->vif = vif;
kobject_uevent(&dev->dev.kobj, KOBJ_ONLINE);
return 0;
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] netback: don't store invalid vif pointer
2014-12-09 11:47 [PATCH] netback: don't store invalid vif pointer Jan Beulich
@ 2014-12-09 12:08 ` Ian Campbell
2014-12-09 23:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Ian Campbell @ 2014-12-09 12:08 UTC (permalink / raw)
To: Jan Beulich; +Cc: Wei Liu, xen-devel, netdev
On Tue, 2014-12-09 at 11:47 +0000, Jan Beulich wrote:
> When xenvif_alloc() fails, it returns a non-NULL error indicator. To
> avoid eventual races, we shouldn't store that into struct backend_info
> as readers of it only check for NULL.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] netback: don't store invalid vif pointer
2014-12-09 11:47 [PATCH] netback: don't store invalid vif pointer Jan Beulich
2014-12-09 12:08 ` Ian Campbell
@ 2014-12-09 23:30 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-12-09 23:30 UTC (permalink / raw)
To: JBeulich; +Cc: wei.liu2, Ian.Campbell, xen-devel, netdev
From: "Jan Beulich" <JBeulich@suse.com>
Date: Tue, 09 Dec 2014 11:47:04 +0000
> When xenvif_alloc() fails, it returns a non-NULL error indicator. To
> avoid eventual races, we shouldn't store that into struct backend_info
> as readers of it only check for NULL.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-09 23:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-09 11:47 [PATCH] netback: don't store invalid vif pointer Jan Beulich
2014-12-09 12:08 ` Ian Campbell
2014-12-09 23:30 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).