From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBF4EC43381 for ; Tue, 19 Feb 2019 08:09:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ACD3E21903 for ; Tue, 19 Feb 2019 08:09:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="ZW2Bc0NH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727400AbfBSIJn (ORCPT ); Tue, 19 Feb 2019 03:09:43 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:43106 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725768AbfBSIJn (ORCPT ); Tue, 19 Feb 2019 03:09:43 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id x1J89ZnW024458; Tue, 19 Feb 2019 02:09:35 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1550563775; bh=uayRR8vC7MMtEg8XIjp1pbE/25W9SWDYmkbjxlSNOlQ=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=ZW2Bc0NHGseH5Urf/KkmzpxL7VpIMbBgMqUxmJLX/0lsHDIIhpZgEWBLdloTH4RVB qjmLuhm399WNdI/QyytHUjX3ADI5Wt2EQB86aiJ4+TFnvZ1kz5zSevaaSW7jt15138 uQBr167GGD+huq1tz8raLni+c0lDA4HiBNM6EJrs= Received: from DLEE109.ent.ti.com (dlee109.ent.ti.com [157.170.170.41]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x1J89Y3B103044 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 19 Feb 2019 02:09:34 -0600 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Tue, 19 Feb 2019 02:09:33 -0600 Received: from dflp32.itg.ti.com (10.64.6.15) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Tue, 19 Feb 2019 02:09:32 -0600 Received: from [192.168.2.6] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp32.itg.ti.com (8.14.3/8.13.8) with ESMTP id x1J89UOL021836; Tue, 19 Feb 2019 02:09:30 -0600 Subject: Re: [PATCH net-next v3 0/2] net: phy: at803x: Update delays for RGMII modes To: Vinod Koul , David S Miller CC: , Bjorn Andersson , , Niklas Cassel , Andrew Lunn , Florian Fainelli , "Nori, Sekhar" , Marc Gonzalez References: <20190219061800.31025-1-vkoul@kernel.org> From: Peter Ujfalusi Message-ID: <141dced0-aae3-e283-6579-a13cd8452e72@ti.com> Date: Tue, 19 Feb 2019 10:09:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190219061800.31025-1-vkoul@kernel.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Vinod, On 19/02/2019 8.17, Vinod Koul wrote: > Peter[1] reported that patch cd28d1d6e52e: ("net: phy: at803x: Disable > phy delay for RGMII mode") caused regression on am335x-evmsk board. > This board expects the Phy delay to be enabled but specified RGMII mode > which refers to delays being disabled. So fix this by disabling delay only > for RGMII mode and enable for RGMII_ID and RGMII_TXID/RXID modes. > > While at it, as pointed by Dave, don't inline the helpers. > > [1]: https://www.spinics.net/lists/netdev/msg550749.html Not sure what was changed since v2, but with https://patchwork.ozlabs.org/project/netdev/list/?series=92672 ethernet is working on am335x-evmsk. thank you: Tested-by: Peter Ujfalusi > Vinod Koul (2): > net: phy: at803x: don't inline helpers > net: phy: at803x: disable delay only for RGMII mode > > drivers/net/phy/at803x.c | 51 ++++++++++++++++++++++++++++++---------- > 1 file changed, 38 insertions(+), 13 deletions(-) > - Péter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki