From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Kirsher Subject: Re: [PATCH net-next v1 4/5] ixgbevf: Add RSS Key query code Date: Wed, 31 Dec 2014 10:32:53 -0800 Message-ID: <1420050773.31582.71.camel@jtkirshe-mobl> References: <1420019519-18139-1-git-send-email-vladz@cloudius-systems.com> <1420019519-18139-5-git-send-email-vladz@cloudius-systems.com> <1420043307.31582.53.camel@jtkirshe-mobl> <54A43A67.9020407@cloudius-systems.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-l5xXsZsvMF3PNuSQ0Cin" Cc: netdev@vger.kernel.org, gleb@cloudius-systems.com, avi@cloudius-systems.com To: Vlad Zolotarov , Alexander Duyck Return-path: Received: from mga11.intel.com ([192.55.52.93]:43592 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751528AbaLaScz (ORCPT ); Wed, 31 Dec 2014 13:32:55 -0500 In-Reply-To: <54A43A67.9020407@cloudius-systems.com> Sender: netdev-owner@vger.kernel.org List-ID: --=-l5xXsZsvMF3PNuSQ0Cin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2014-12-31 at 20:03 +0200, Vlad Zolotarov wrote: > On 12/31/14 18:28, Jeff Kirsher wrote: > > On Wed, 2014-12-31 at 11:51 +0200, Vlad Zolotarov wrote: > >> Signed-off-by: Vlad Zolotarov > >> --- > >> New in v1 (compared to RFC): > >> - Use "if-else" statement instead of a "switch-case" for a > single > >> option case > >> (in ixgbevf_get_rss_key()). > >> > >> --- > >> drivers/net/ethernet/intel/ixgbevf/mbx.h | 2 ++ > >> drivers/net/ethernet/intel/ixgbevf/vf.c | 44 > >> ++++++++++++++++++++++++++++++++ > >> drivers/net/ethernet/intel/ixgbevf/vf.h | 1 + > >> 3 files changed, 47 insertions(+) > > Just caught this now, sorry but your patch description is sparse > (i.e. > > non-existent). I know that the title of the patch pretty much tells > > what you are doing, but it would be nice to have a bit more detail > as to > > why (like your first patch). >=20 > I've sent a v2 where I tried to address your last remarks. Pls., note=20 > that the whole series "why" motivation is located in the PATCH0 and > in=20 > the final PATCH5: adding a new ethtool options for 82599 VF devices. Thanks v2 appears fine with regards to code/patch format goes. Alex Duyck appears to have provided feedback on the series, which is a concern for me. I have dropped v1 (since v2 is out), but I am going to hold off on pulling in v2 until Alex's concerns have been addressed. --=-l5xXsZsvMF3PNuSQ0Cin Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCgAGBQJUpEFVAAoJEOVv75VaS+3OtZMP/ji364F+MuFjYdLGu8OCIwl9 CJehs9PGHmPo4PTkMjeiSUDwI6D/l8KKA8zaxg6pldR8pSlbUluwUwXqrbXqkBah /RPWMzBxPGLsjesfTJidhjHvcb1jCkLseo3tbr2maU7/LQAmU+QKowHtPi6JYBBu /ovGkxcshe0LNCr7h9xCcD5MTC/cadYfbTB+9VofidFqKZa0fsPB+Ryyo7FEoM4Z ocVNNaeO8B8ihibPfM6LuHkgfxuzpMxssPElImPkysKdxLmkBMqGyjI6aFPT+sdv 6QxBEPLSFbvBvTU2w8yWbn99QC8cPCNm2R6v7FKeBDr/a+4q2BhyZBtT3bLP6WEV epxExgQnWkxxSvkqMY2aSQmWSEb72buAYK+CPqGG8bw6yktHoT6373Eb3Ss+GZF5 B+6gjXzOlynky6C29cuShXC8DfN3h+8TiSlqPMclwmEFK02sNAPnZram/DhZfr1A LuT0++vYpArVJWvvXh2XGCq/yHZLSovmCLih6EYBa2+egO2ehy79uKcbi25zpiOA 6+Jsjrp94Omu+hJKH632raPSEO+7CasOKHWqfV5eyQHznyx8iEm0jb6U0gdDfwA8 5daP1qRFwlRZHHCLoi7uIp2cpjBUUEInJ5u2gVSCkCF51fIUd+np3TK2gM0HFomw YloAWmPpXbHpwrrm7p3C =SUk0 -----END PGP SIGNATURE----- --=-l5xXsZsvMF3PNuSQ0Cin--