From: Ying Xue <ying.xue@windriver.com>
To: <tgraf@suug.ch>
Cc: jon.maloy@ericsson.com, netdev@vger.kernel.org,
Paul.Gortmaker@windriver.com,
tipc-discussion@lists.sourceforge.net, davem@davemloft.net
Subject: [PATCH net-next v2 4/7] rhashtable: future table needs to be traversed when remove an object
Date: Wed, 7 Jan 2015 13:41:55 +0800 [thread overview]
Message-ID: <1420609318-3261-5-git-send-email-ying.xue@windriver.com> (raw)
In-Reply-To: <1420609318-3261-1-git-send-email-ying.xue@windriver.com>
When remove an object from hash table, we currently only traverse old
bucket table to check whether the object exists. If the object is not
found in it, we will try again. But in the second search loop, we still
search the object from the old table instead of future table. As a
result, the object may be not removed from hash table especially when
resizing is currently in progress and the object is just saved in the
future table.
Signed-off-by: Ying Xue <ying.xue@windriver.com>
Cc: Thomas Graf <tgraf@suug.ch>
---
lib/rhashtable.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/rhashtable.c b/lib/rhashtable.c
index 4430233..1aef942 100644
--- a/lib/rhashtable.c
+++ b/lib/rhashtable.c
@@ -608,10 +608,10 @@ restart:
return true;
}
- if (tbl != rht_dereference_rcu(ht->tbl, ht)) {
+ if (tbl != rht_dereference_rcu(ht->future_tbl, ht)) {
spin_unlock_bh(lock);
- tbl = rht_dereference_rcu(ht->tbl, ht);
+ tbl = rht_dereference_rcu(ht->future_tbl, ht);
hash = head_hashfn(ht, tbl, obj);
lock = bucket_lock(tbl, hash);
--
1.7.9.5
------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
next prev parent reply other threads:[~2015-01-07 5:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 5:41 [PATCH net-next v2 0/7] Involve rhashtable_lookup_insert routine Ying Xue
2015-01-07 5:41 ` [PATCH net-next v2 1/7] rhashtable: optimize rhashtable_lookup routine Ying Xue
2015-01-07 5:41 ` [PATCH net-next v2 2/7] rhashtable: introduce rhashtable_wakeup_worker helper function Ying Xue
2015-01-07 9:34 ` Thomas Graf
2015-01-07 5:41 ` [PATCH net-next v2 3/7] rhashtable: involve rhashtable_lookup_insert routine Ying Xue
2015-01-07 5:41 ` Ying Xue [this message]
2015-01-07 9:39 ` [PATCH net-next v2 4/7] rhashtable: future table needs to be traversed when remove an object Thomas Graf
2015-01-07 5:41 ` [PATCH net-next v2 5/7] rhashtable: avoid unnecessary wakeup for worker queue Ying Xue
2015-01-07 9:50 ` Thomas Graf
2015-01-07 10:28 ` Ying Xue
2015-01-07 5:41 ` [PATCH net-next v2 6/7] rhashtable: initialize atomic nelems variable Ying Xue
2015-01-07 9:53 ` Thomas Graf
2015-01-07 10:26 ` Ying Xue
2015-01-07 10:36 ` Thomas Graf
2015-01-07 5:41 ` [PATCH net-next v2 7/7] tipc: convert tipc reference table to use generic rhashtable Ying Xue
2015-01-07 9:54 ` [PATCH net-next v2 0/7] Involve rhashtable_lookup_insert routine Thomas Graf
2015-01-09 3:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420609318-3261-5-git-send-email-ying.xue@windriver.com \
--to=ying.xue@windriver.com \
--cc=Paul.Gortmaker@windriver.com \
--cc=davem@davemloft.net \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=tipc-discussion@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).