From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vadim Kochan Subject: [PATCH iproute2 3/3] ip netns: Delete all netns Date: Wed, 7 Jan 2015 13:04:22 +0200 Message-ID: <1420628662-9930-4-git-send-email-vadim4j@gmail.com> References: <1420628662-9930-1-git-send-email-vadim4j@gmail.com> Cc: Vadim Kochan To: netdev@vger.kernel.org Return-path: Received: from mail-la0-f50.google.com ([209.85.215.50]:56801 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751330AbbAGLOv (ORCPT ); Wed, 7 Jan 2015 06:14:51 -0500 Received: by mail-la0-f50.google.com with SMTP id pn19so2719071lab.9 for ; Wed, 07 Jan 2015 03:14:50 -0800 (PST) In-Reply-To: <1420628662-9930-1-git-send-email-vadim4j@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: From: Vadim Kochan Allow delete all namespace names by: $ ip netns del all Signed-off-by: Vadim Kochan --- ip/ipnetns.c | 24 +++++++++++++++--------- man/man8/ip-netns.8 | 12 ++++++++++-- 2 files changed, 25 insertions(+), 11 deletions(-) diff --git a/ip/ipnetns.c b/ip/ipnetns.c index b5a6f57..20707b8 100644 --- a/ip/ipnetns.c +++ b/ip/ipnetns.c @@ -274,18 +274,11 @@ static int netns_identify(int argc, char **argv) } -static int netns_delete(int argc, char **argv) +static int on_netns_del(char *nsname, void *arg) { - const char *name; char netns_path[MAXPATHLEN]; - if (argc < 1) { - fprintf(stderr, "No netns name specified\n"); - return -1; - } - - name = argv[0]; - snprintf(netns_path, sizeof(netns_path), "%s/%s", NETNS_RUN_DIR, name); + snprintf(netns_path, sizeof(netns_path), "%s/%s", NETNS_RUN_DIR, nsname); umount2(netns_path, MNT_DETACH); if (unlink(netns_path) < 0) { fprintf(stderr, "Cannot remove namespace file \"%s\": %s\n", @@ -295,6 +288,19 @@ static int netns_delete(int argc, char **argv) return 0; } +static int netns_delete(int argc, char **argv) +{ + if (argc < 1) { + fprintf(stderr, "No netns name specified\n"); + return -1; + } + + if (strcmp(argv[0], "all") == 0) + return netns_foreach(on_netns_del, NULL); + + return on_netns_del(argv[0], NULL); +} + static int create_netns_dir(void) { /* Create the base netns directory if it doesn't exist */ diff --git a/man/man8/ip-netns.8 b/man/man8/ip-netns.8 index 70ea4f0..e56068e 100644 --- a/man/man8/ip-netns.8 +++ b/man/man8/ip-netns.8 @@ -16,10 +16,14 @@ ip-netns \- process network namespace management .BR "ip netns" " { " list " } " .ti -8 -.BR "ip netns" " { " add " | " delete " } " +.B ip netns add .I NETNSNAME .ti -8 +.B ip netns del +.RI "{ " NETNSNAME " | " all " }" + +.ti -8 .BR "ip netns identify" .RI "[ " PID " ]" @@ -76,7 +80,7 @@ If NAME is available in /var/run/netns/ this command creates a new network namespace and assigns NAME. .TP -.B ip netns delete NAME - delete the name of a network namespace +.B ip netns delete { NAME | all } - delete the name of a network namespace(s) .sp If NAME is present in /var/run/netns it is umounted and the mount point is removed. If this is the last user of the network namespace the @@ -84,6 +88,10 @@ network namespace will be freed, otherwise the network namespace persists until it has no more users. ip netns delete may fail if the mount point is in use in another mount namespace. +If +.B all +was specified then all the network namespace names will be removed. + .TP .B ip netns identify [PID] - Report network namespaces names for process .sp -- 2.1.3