* [PATCH net-next] ipv6: directly include libc-compat.h in ipv6.h
@ 2015-01-12 19:29 Willem de Bruijn
2015-01-13 18:50 ` Cong Wang
2015-01-13 21:33 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Willem de Bruijn @ 2015-01-12 19:29 UTC (permalink / raw)
To: netdev; +Cc: davem, xiyou.wangcong, Willem de Bruijn
From: Willem de Bruijn <willemb@google.com>
Patch 3b50d9029809 ("ipv6: fix redefinition of in6_pktinfo ...")
fixed a libc compatibility issue in ipv6 structure definitions
as described in include/uapi/linux/libc-compat.h.
It relies on including linux/in6.h to include libc-compat.h itself.
Include that file directly to clearly communicate the dependency
(libc-compat.h: "This include must be as early as possible").
Signed-off-by: Willem de Bruijn <willemb@google.com>
----
As discussed in http://patchwork.ozlabs.org/patch/427384/
---
include/uapi/linux/ipv6.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/ipv6.h b/include/uapi/linux/ipv6.h
index b9b1b7d..73cb02d 100644
--- a/include/uapi/linux/ipv6.h
+++ b/include/uapi/linux/ipv6.h
@@ -1,6 +1,7 @@
#ifndef _UAPI_IPV6_H
#define _UAPI_IPV6_H
+#include <linux/libc-compat.h>
#include <linux/types.h>
#include <linux/in6.h>
#include <asm/byteorder.h>
--
2.2.0.rc0.207.ga3a616c
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ipv6: directly include libc-compat.h in ipv6.h
2015-01-12 19:29 [PATCH net-next] ipv6: directly include libc-compat.h in ipv6.h Willem de Bruijn
@ 2015-01-13 18:50 ` Cong Wang
2015-01-13 21:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Cong Wang @ 2015-01-13 18:50 UTC (permalink / raw)
To: Willem de Bruijn; +Cc: Linux Kernel Network Developers, David Miller
On Mon, Jan 12, 2015 at 11:29 AM, Willem de Bruijn <willemb@google.com> wrote:
> From: Willem de Bruijn <willemb@google.com>
>
> Patch 3b50d9029809 ("ipv6: fix redefinition of in6_pktinfo ...")
> fixed a libc compatibility issue in ipv6 structure definitions
> as described in include/uapi/linux/libc-compat.h.
>
> It relies on including linux/in6.h to include libc-compat.h itself.
> Include that file directly to clearly communicate the dependency
> (libc-compat.h: "This include must be as early as possible").
>
> Signed-off-by: Willem de Bruijn <willemb@google.com>
>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Thanks for the patch!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] ipv6: directly include libc-compat.h in ipv6.h
2015-01-12 19:29 [PATCH net-next] ipv6: directly include libc-compat.h in ipv6.h Willem de Bruijn
2015-01-13 18:50 ` Cong Wang
@ 2015-01-13 21:33 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2015-01-13 21:33 UTC (permalink / raw)
To: willemb; +Cc: netdev, xiyou.wangcong
From: Willem de Bruijn <willemb@google.com>
Date: Mon, 12 Jan 2015 14:29:34 -0500
> From: Willem de Bruijn <willemb@google.com>
>
> Patch 3b50d9029809 ("ipv6: fix redefinition of in6_pktinfo ...")
> fixed a libc compatibility issue in ipv6 structure definitions
> as described in include/uapi/linux/libc-compat.h.
>
> It relies on including linux/in6.h to include libc-compat.h itself.
> Include that file directly to clearly communicate the dependency
> (libc-compat.h: "This include must be as early as possible").
>
> Signed-off-by: Willem de Bruijn <willemb@google.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-13 21:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-12 19:29 [PATCH net-next] ipv6: directly include libc-compat.h in ipv6.h Willem de Bruijn
2015-01-13 18:50 ` Cong Wang
2015-01-13 21:33 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).