* [PATCH] net/fsl: fix a bug in xgmac_mdio
@ 2015-01-13 2:30 shh.xie
2015-01-13 21:43 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: shh.xie @ 2015-01-13 2:30 UTC (permalink / raw)
To: netdev, davem; +Cc: Shaohui Xie
From: Shaohui Xie <Shaohui.Xie@freescale.com>
There is a bug in xgmac_mdio_read when clear the bit MDIO_STAT_ENC,
which '&' is missed in 'mdio_stat &= ~MDIO_STAT_ENC'.
Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
---
drivers/net/ethernet/freescale/xgmac_mdio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
index e0fc3d1..a492e50 100644
--- a/drivers/net/ethernet/freescale/xgmac_mdio.c
+++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
@@ -156,7 +156,7 @@ static int xgmac_mdio_read(struct mii_bus *bus, int phy_id, int regnum)
mdio_stat |= MDIO_STAT_ENC;
} else {
dev_addr = regnum & 0x1f;
- mdio_stat = ~MDIO_STAT_ENC;
+ mdio_stat &= ~MDIO_STAT_ENC;
}
out_be32(®s->mdio_stat, mdio_stat);
--
1.8.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/fsl: fix a bug in xgmac_mdio
2015-01-13 2:30 [PATCH] net/fsl: fix a bug in xgmac_mdio shh.xie
@ 2015-01-13 21:43 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-01-13 21:43 UTC (permalink / raw)
To: shh.xie; +Cc: netdev, Shaohui.Xie
From: <shh.xie@gmail.com>
Date: Tue, 13 Jan 2015 10:30:31 +0800
> From: Shaohui Xie <Shaohui.Xie@freescale.com>
>
> There is a bug in xgmac_mdio_read when clear the bit MDIO_STAT_ENC,
> which '&' is missed in 'mdio_stat &= ~MDIO_STAT_ENC'.
>
> Signed-off-by: Shaohui Xie <Shaohui.Xie@freescale.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-13 21:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-13 2:30 [PATCH] net/fsl: fix a bug in xgmac_mdio shh.xie
2015-01-13 21:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).