* [PATCH net 0/3]tg3: synchronize_irq() should be called without taking locks
@ 2015-01-14 6:30 Prashant Sreedharan
2015-01-14 15:57 ` Peter Hurley
0 siblings, 1 reply; 3+ messages in thread
From: Prashant Sreedharan @ 2015-01-14 6:30 UTC (permalink / raw)
To: davem; +Cc: netdev, mchan, peter, Prashant Sreedharan
Prashant Sreedharan (3):
tg3_timer() should grab tp->lock before checking for tp->irq_sync
tg3_reset_task() needs to use rtnl_lock to synchronize
Release tp->lock before invoking synchronize_irq()
Our QA team is validating this patch set, we need few days before merging
drivers/net/ethernet/broadcom/tg3.c | 23 ++++++++++++++++++++---
1 files changed, 20 insertions(+), 3 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net 0/3]tg3: synchronize_irq() should be called without taking locks
2015-01-14 6:30 [PATCH net 0/3]tg3: synchronize_irq() should be called without taking locks Prashant Sreedharan
@ 2015-01-14 15:57 ` Peter Hurley
2015-01-14 19:04 ` Prashant Sreedharan
0 siblings, 1 reply; 3+ messages in thread
From: Peter Hurley @ 2015-01-14 15:57 UTC (permalink / raw)
To: Prashant Sreedharan, davem; +Cc: netdev, mchan
On 01/14/2015 01:30 AM, Prashant Sreedharan wrote:
> Prashant Sreedharan (3):
> tg3_timer() should grab tp->lock before checking for tp->irq_sync
> tg3_reset_task() needs to use rtnl_lock to synchronize
> Release tp->lock before invoking synchronize_irq()
Thanks!
For series:
Reported-by: Peter Hurley <peter@hurleysoftware.com>
Tested-by: Peter Hurley <peter@hurleysoftware.com>
But maybe one of these patches should reference that this fixes
BUG: sleeping function... so that others can quickly find this
fix (if they're bisecting or whatever). For the same reason, it
might be useful for this series to be just one patch.
Regards,
Peter Hurley
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net 0/3]tg3: synchronize_irq() should be called without taking locks
2015-01-14 15:57 ` Peter Hurley
@ 2015-01-14 19:04 ` Prashant Sreedharan
0 siblings, 0 replies; 3+ messages in thread
From: Prashant Sreedharan @ 2015-01-14 19:04 UTC (permalink / raw)
To: Peter Hurley; +Cc: davem, netdev, mchan
On Wed, 2015-01-14 at 10:57 -0500, Peter Hurley wrote:
> On 01/14/2015 01:30 AM, Prashant Sreedharan wrote:
> > Prashant Sreedharan (3):
> > tg3_timer() should grab tp->lock before checking for tp->irq_sync
> > tg3_reset_task() needs to use rtnl_lock to synchronize
> > Release tp->lock before invoking synchronize_irq()
>
> Thanks!
>
> For series:
>
> Reported-by: Peter Hurley <peter@hurleysoftware.com>
> Tested-by: Peter Hurley <peter@hurleysoftware.com>
>
> But maybe one of these patches should reference that this fixes
> BUG: sleeping function... so that others can quickly find this
> fix (if they're bisecting or whatever).
Sure will add
> For the same reason, it
> might be useful for this series to be just one patch.
These are logical different sections of code, I prefer them to be small
patches.
>
> Regards,
> Peter Hurley
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-14 19:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-14 6:30 [PATCH net 0/3]tg3: synchronize_irq() should be called without taking locks Prashant Sreedharan
2015-01-14 15:57 ` Peter Hurley
2015-01-14 19:04 ` Prashant Sreedharan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).