From: Johannes Berg <johannes@sipsolutions.net>
To: Jeff Layton <jeff.layton@primarydata.com>
Cc: netdev@vger.kernel.org
Subject: Re: [ 2375.793397] WARNING: CPU: 0 PID: 1149 at net/netlink/genetlink.c:1037 genl_unbind+0xc0/0xd0()
Date: Thu, 15 Jan 2015 00:25:46 +0100 [thread overview]
Message-ID: <1421277946.1950.38.camel@sipsolutions.net> (raw)
In-Reply-To: <1421275700.1950.34.camel@sipsolutions.net>
On Wed, 2015-01-14 at 23:48 +0100, Johannes Berg wrote:
> > [ 2375.793396] ------------[ cut here ]------------
> > [ 2375.793397] WARNING: CPU: 0 PID: 1149 at net/netlink/genetlink.c:1037 genl_unbind+0xc0/0xd0()
>
> This warning is supposed to happen only when you somehow manage to
> unsubscribe from a generic netlink group that doesn't actually exist, or
> so.
Ok - after long deliberation I found a way to trigger it. It requires
that you leave a multicast group (likely by destroying a socket) at the
same time as the kernel unregisters the generic netlink group. I have no
idea what generic netlink group you might be using here, but I could
reproduce it with a strategically placed delay in the netlink code and
the nl80211 genl group by opening a socket, closing the socket, and
removing the cfg80211 module (to unregister the nl80211 genl group)
while the socket was still being closed.
I'll think about a fix tomorrow - it doesn't seem trivial due to
possible locking concerns.
On the bright side, I cannot see a way to reproduce this without
removing the genl family at the same time - which is good because it
means that I've just again audited the case I was worried about (the
bind/unbind not being symmetric) - it is asymmetric but only in the case
of genl family removal which seems reasonable (but I should document
it.)
johannes
next prev parent reply other threads:[~2015-01-14 23:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 21:13 [ 2375.793397] WARNING: CPU: 0 PID: 1149 at net/netlink/genetlink.c:1037 genl_unbind+0xc0/0xd0() Jeff Layton
2015-01-14 22:48 ` Johannes Berg
2015-01-14 23:25 ` Johannes Berg [this message]
2015-01-15 2:20 ` Jeff Layton
2015-01-15 8:37 ` Johannes Berg
[not found] ` <20150115071426.563573e7@tlielax.poochiereds.net>
[not found] ` <1421324985.1962.5.camel@sipsolutions.net>
2015-01-15 12:49 ` Jeff Layton
2015-01-15 13:01 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421277946.1950.38.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=jeff.layton@primarydata.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).