From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: [PATCH 3/3] genetlink: synchronize socket closing and family removal Date: Thu, 15 Jan 2015 21:55:06 +0100 Message-ID: <1421355306.1962.14.camel@sipsolutions.net> References: <1421319885-31779-1-git-send-email-johannes@sipsolutions.net> <1421319885-31779-3-git-send-email-johannes@sipsolutions.net> <20150115.145007.184934220260873768.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, jeff.layton@primarydata.com, sedat.dilek@gmail.com To: David Miller Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:38721 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753670AbbAOUzL (ORCPT ); Thu, 15 Jan 2015 15:55:11 -0500 In-Reply-To: <20150115.145007.184934220260873768.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, 2015-01-15 at 14:50 -0500, David Miller wrote: > From: Johannes Berg > Date: Thu, 15 Jan 2015 12:04:45 +0100 > > > + atomic_dec(&genl_sk_destructing_cnt); > > + printk(KERN_DEBUG "dec destructing\n"); > > + wake_up(&genl_sk_destructing_waitq); > > Hmmm, maybe only wakeup if "!atomic_dec_and_test()"? Yes, good point. And, umm, how the hell did I manage to leave the printk() in there? johannes