From: Govindarajulu Varadarajan <_govind@gmx.com>
To: davem@davemloft.net, netdev@vger.kernel.org, ariel.elior@qlogic.com
Cc: ssujith@cisco.com, benve@cisco.com,
Govindarajulu Varadarajan <_govind@gmx.com>
Subject: [PATCH net 1/2] enic: fix rx napi poll return value
Date: Tue, 20 Jan 2015 18:46:15 +0530 [thread overview]
Message-ID: <1421759776-376-2-git-send-email-_govind@gmx.com> (raw)
In-Reply-To: <1421759776-376-1-git-send-email-_govind@gmx.com>
With the commit d75b1ade567ffab ("net: less interrupt masking in NAPI") napi repoll
is done only when work_done == budget. When we are in busy_poll we return 0 in
napi_poll. We should return budget.
Signed-off-by: Govindarajulu Varadarajan <_govind@gmx.com>
---
drivers/net/ethernet/cisco/enic/enic_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/cisco/enic/enic_main.c b/drivers/net/ethernet/cisco/enic/enic_main.c
index b29e027..e356afa 100644
--- a/drivers/net/ethernet/cisco/enic/enic_main.c
+++ b/drivers/net/ethernet/cisco/enic/enic_main.c
@@ -1335,7 +1335,7 @@ static int enic_poll_msix_rq(struct napi_struct *napi, int budget)
int err;
if (!enic_poll_lock_napi(&enic->rq[rq]))
- return work_done;
+ return budget;
/* Service RQ
*/
--
2.2.2
next prev parent reply other threads:[~2015-01-20 13:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 13:16 [PATCH net 0/2] fix napi return value Govindarajulu Varadarajan
2015-01-20 13:16 ` Govindarajulu Varadarajan [this message]
2015-01-25 6:39 ` [PATCH net 1/2] enic: fix rx napi poll " David Miller
2015-01-20 13:16 ` [PATCH net 2/2] bnx2x: fix napi poll return value for repoll Govindarajulu Varadarajan
2015-01-20 14:51 ` Eric Dumazet
2015-01-20 14:54 ` Eric Dumazet
2015-01-20 15:26 ` Govindarajulu Varadarajan
2015-01-20 15:24 ` Govindarajulu Varadarajan
2015-01-20 15:44 ` Eric Dumazet
2015-01-25 6:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421759776-376-2-git-send-email-_govind@gmx.com \
--to=_govind@gmx.com \
--cc=ariel.elior@qlogic.com \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ssujith@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).