From: <erik.hugne@ericsson.com>
To: <richard.alpe@ericsson.com>, <netdev@vger.kernel.org>,
<jon.maloy@ericsson.com>, <ying.xue@windriver.com>
Cc: tipc-discussion@lists.sourceforge.net
Subject: [PATCH net-next 2/2] flow_dissector: add tipc support
Date: Thu, 22 Jan 2015 17:10:32 +0100 [thread overview]
Message-ID: <1421943032-29924-2-git-send-email-erik.hugne@ericsson.com> (raw)
In-Reply-To: <1421943032-29924-1-git-send-email-erik.hugne@ericsson.com>
From: Erik Hugne <erik.hugne@ericsson.com>
The flows are hashed on the sending node address, which allows us
to spread out the TIPC link processing to RPS enabled cores. There
is no point to include the destination address in the hash as that
will always be the same for all inbound links. We have experimented
with a 3-tuple hash over [srcnode, sport, dport], but this showed to
give slightly lower performance because of increased lock contention
when the same link was handled by multiple cores.
Signed-off-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Erik Hugne <erik.hugne@ericsson.com>
Reviewed-by: Jon Maloy <jon.maloy@ericsson.com>
---
net/core/flow_dissector.c | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c
index 4508493..beb83d1 100644
--- a/net/core/flow_dissector.c
+++ b/net/core/flow_dissector.c
@@ -178,6 +178,20 @@ ipv6:
return false;
}
}
+ case htons(ETH_P_TIPC): {
+ struct {
+ __be32 pre[3];
+ __be32 srcnode;
+ } *hdr, _hdr;
+ hdr = __skb_header_pointer(skb, nhoff, sizeof(_hdr), data, hlen, &_hdr);
+ if (!hdr)
+ return false;
+ flow->src = hdr->srcnode;
+ flow->dst = 0;
+ flow->n_proto = proto;
+ flow->thoff = (u16)nhoff;
+ return true;
+ }
case htons(ETH_P_FCOE):
flow->thoff = (u16)(nhoff + FCOE_HEADER_LEN);
/* fall through */
--
2.1.3
------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
next prev parent reply other threads:[~2015-01-22 16:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 16:10 [PATCH net-next 1/2] tipc: fix excessive network event logging erik.hugne
2015-01-22 16:10 ` erik.hugne [this message]
2015-01-22 17:29 ` [PATCH net-next 2/2] flow_dissector: add tipc support Eric Dumazet
2015-01-22 18:38 ` Jon Maloy
2015-01-27 0:57 ` David Miller
2015-01-27 12:08 ` Erik Hugne
2015-01-27 14:40 ` Eric Dumazet
2015-01-27 1:04 ` David Miller
2015-01-22 17:24 ` [PATCH net-next 1/2] tipc: fix excessive network event logging Joe Perches
2015-01-23 6:44 ` Erik Hugne
2015-01-27 1:04 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421943032-29924-2-git-send-email-erik.hugne@ericsson.com \
--to=erik.hugne@ericsson.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=richard.alpe@ericsson.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).