* [PATCH] net: ieee802154: cc2520: Fix coding style issues
@ 2015-01-23 9:26 Mohammad Jamal
2015-01-23 9:39 ` Varka Bhadram
2015-01-23 12:37 ` Sergei Shtylyov
0 siblings, 2 replies; 4+ messages in thread
From: Mohammad Jamal @ 2015-01-23 9:26 UTC (permalink / raw)
To: varkabhadram, alex.aring, linux-wpan, netdev, linux-kernel; +Cc: Mohammad Jamal
This patch solves the coding style issues such as space after ,
and removes the blank lines
Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com>
---
drivers/net/ieee802154/cc2520.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
index f9df9fa..dd129be 100644
--- a/drivers/net/ieee802154/cc2520.c
+++ b/drivers/net/ieee802154/cc2520.c
@@ -513,7 +513,6 @@ err_tx:
return rc;
}
-
static int cc2520_rx(struct cc2520_private *priv)
{
u8 len = 0, lqi = 0, bytes = 1;
@@ -551,14 +550,14 @@ cc2520_ed(struct ieee802154_hw *hw, u8 *level)
u8 rssi;
int ret;
- ret = cc2520_read_register(priv , CC2520_RSSISTAT, &status);
+ ret = cc2520_read_register(priv, CC2520_RSSISTAT, &status);
if (ret)
return ret;
if (status != RSSI_VALID)
return -EINVAL;
- ret = cc2520_read_register(priv , CC2520_RSSI, &rssi);
+ ret = cc2520_read_register(priv, CC2520_RSSI, &rssi);
if (ret)
return ret;
@@ -947,7 +946,6 @@ static int cc2520_probe(struct spi_device *spi)
if (ret)
goto err_hw_init;
-
gpio_set_value(pdata->vreg, HIGH);
usleep_range(100, 150);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] net: ieee802154: cc2520: Fix coding style issues
2015-01-23 9:26 [PATCH] net: ieee802154: cc2520: Fix coding style issues Mohammad Jamal
@ 2015-01-23 9:39 ` Varka Bhadram
2015-01-23 12:37 ` Sergei Shtylyov
1 sibling, 0 replies; 4+ messages in thread
From: Varka Bhadram @ 2015-01-23 9:39 UTC (permalink / raw)
To: Mohammad Jamal
Cc: Alexander Aring, linux-wpan - ML, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Hi Mohammad Jamal,
These changes already there in the current bluetooth-next tree.
On Fri, Jan 23, 2015 at 2:56 PM, Mohammad Jamal
<md.jamalmohiuddin@gmail.com> wrote:
> This patch solves the coding style issues such as space after ,
> and removes the blank lines
>
> Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com>
> ---
> drivers/net/ieee802154/cc2520.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
> index f9df9fa..dd129be 100644
> --- a/drivers/net/ieee802154/cc2520.c
> +++ b/drivers/net/ieee802154/cc2520.c
> @@ -513,7 +513,6 @@ err_tx:
> return rc;
> }
>
> -
> static int cc2520_rx(struct cc2520_private *priv)
> {
> u8 len = 0, lqi = 0, bytes = 1;
> @@ -551,14 +550,14 @@ cc2520_ed(struct ieee802154_hw *hw, u8 *level)
> u8 rssi;
> int ret;
>
> - ret = cc2520_read_register(priv , CC2520_RSSISTAT, &status);
> + ret = cc2520_read_register(priv, CC2520_RSSISTAT, &status);
> if (ret)
> return ret;
>
> if (status != RSSI_VALID)
> return -EINVAL;
>
> - ret = cc2520_read_register(priv , CC2520_RSSI, &rssi);
> + ret = cc2520_read_register(priv, CC2520_RSSI, &rssi);
> if (ret)
> return ret;
>
> @@ -947,7 +946,6 @@ static int cc2520_probe(struct spi_device *spi)
> if (ret)
> goto err_hw_init;
>
> -
> gpio_set_value(pdata->vreg, HIGH);
> usleep_range(100, 150);
>
> --
> 1.7.9.5
>
--
Thanks and Regards,
Varka Bhadram.
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: ieee802154: cc2520: Fix coding style issues
2015-01-23 9:26 [PATCH] net: ieee802154: cc2520: Fix coding style issues Mohammad Jamal
2015-01-23 9:39 ` Varka Bhadram
@ 2015-01-23 12:37 ` Sergei Shtylyov
2015-01-23 12:44 ` Jamal Mohammad
1 sibling, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2015-01-23 12:37 UTC (permalink / raw)
To: Mohammad Jamal, varkabhadram, alex.aring, linux-wpan, netdev,
linux-kernel
Hello.
On 1/23/2015 12:26 PM, Mohammad Jamal wrote:
> This patch solves the coding style issues such as space after ,
s/after/before/?
> and removes the blank lines
Extra blank lines, you mean?
> Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com>
> ---
> drivers/net/ieee802154/cc2520.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
> index f9df9fa..dd129be 100644
> --- a/drivers/net/ieee802154/cc2520.c
> +++ b/drivers/net/ieee802154/cc2520.c
[...]
> @@ -551,14 +550,14 @@ cc2520_ed(struct ieee802154_hw *hw, u8 *level)
> u8 rssi;
> int ret;
>
> - ret = cc2520_read_register(priv , CC2520_RSSISTAT, &status);
> + ret = cc2520_read_register(priv, CC2520_RSSISTAT, &status);
> if (ret)
> return ret;
>
> if (status != RSSI_VALID)
> return -EINVAL;
>
> - ret = cc2520_read_register(priv , CC2520_RSSI, &rssi);
> + ret = cc2520_read_register(priv, CC2520_RSSI, &rssi);
[...]
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] net: ieee802154: cc2520: Fix coding style issues
2015-01-23 12:37 ` Sergei Shtylyov
@ 2015-01-23 12:44 ` Jamal Mohammad
0 siblings, 0 replies; 4+ messages in thread
From: Jamal Mohammad @ 2015-01-23 12:44 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: Varka Bhadram, Alexander Aring, linux-wpan - ML,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
On Fri, Jan 23, 2015 at 6:07 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
> On 1/23/2015 12:26 PM, Mohammad Jamal wrote:
>
>> This patch solves the coding style issues such as space after ,
>
>
> s/after/before/?
>
>> and removes the blank lines
>
>
> Extra blank lines, you mean?
>
>> Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com>
>> ---
>> drivers/net/ieee802154/cc2520.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>
>> diff --git a/drivers/net/ieee802154/cc2520.c
>> b/drivers/net/ieee802154/cc2520.c
>> index f9df9fa..dd129be 100644
>> --- a/drivers/net/ieee802154/cc2520.c
>> +++ b/drivers/net/ieee802154/cc2520.c
>
> [...]
>>
>> @@ -551,14 +550,14 @@ cc2520_ed(struct ieee802154_hw *hw, u8 *level)
>> u8 rssi;
>> int ret;
>>
>> - ret = cc2520_read_register(priv , CC2520_RSSISTAT, &status);
>> + ret = cc2520_read_register(priv, CC2520_RSSISTAT, &status);
>> if (ret)
>> return ret;
>>
>> if (status != RSSI_VALID)
>> return -EINVAL;
>>
>> - ret = cc2520_read_register(priv , CC2520_RSSI, &rssi);
>> + ret = cc2520_read_register(priv, CC2520_RSSI, &rssi);
>
> [...]
>
> WBR, Sergei
>
Sorry for that,
i actually have cloned and linus torvalds git and when i ran
checkpatch.pl i have found some warnings. so this patch was removing
those warnings...as bhadram told that these warnings are already
removed in bluetooth-next tree...so this patch any how fails....
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-23 12:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-23 9:26 [PATCH] net: ieee802154: cc2520: Fix coding style issues Mohammad Jamal
2015-01-23 9:39 ` Varka Bhadram
2015-01-23 12:37 ` Sergei Shtylyov
2015-01-23 12:44 ` Jamal Mohammad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox