Re: [PATCH] net: ieee802154: cc2520: Fix coding style issues

Jamal Mohammad
2015-01-23T12:44:55Z

On Fri, Jan 23, 2015 at 6:07 PM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Hello.
>
> On 1/23/2015 12:26 PM, Mohammad Jamal wrote:
>
>> This patch solves the coding style issues such as space after ,
>
>
> s/after/before/?
>
>> and removes the blank lines
>
>
> Extra blank lines, you mean?
>
>> Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com>
>> ---
>> drivers/net/ieee802154/cc2520.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>
>> diff --git a/drivers/net/ieee802154/cc2520.c
>> b/drivers/net/ieee802154/cc2520.c
>> index f9df9fa..dd129be 100644
>> --- a/drivers/net/ieee802154/cc2520.c
>> +++ b/drivers/net/ieee802154/cc2520.c
>
> [...]
>>
>> @@ -551,14 +550,14 @@ cc2520_ed(struct ieee802154_hw *hw, u8 *level)
>> u8 rssi;
>> int ret;
>>
>> - ret = cc2520_read_register(priv , CC2520_RSSISTAT, &status);
>> + ret = cc2520_read_register(priv, CC2520_RSSISTAT, &status);
>> if (ret)
>> return ret;
>>
>> if (status != RSSI_VALID)
>> return -EINVAL;
>>
>> - ret = cc2520_read_register(priv , CC2520_RSSI, &rssi);
>> + ret = cc2520_read_register(priv, CC2520_RSSI, &rssi);
>
> [...]
>
> WBR, Sergei
>

Sorry for that,

i actually have cloned and linus torvalds git and when i ran
checkpatch.pl i have found some warnings. so this patch was removing
those warnings...as bhadram told that these warnings are already
removed in bluetooth-next tree...so this patch any how fails....