* [PATCH] net: ieee802154: cc2520: fix coding style issue
@ 2015-01-23 9:36 Mohammad Jamal
2015-01-23 9:46 ` Varka Bhadram
0 siblings, 1 reply; 3+ messages in thread
From: Mohammad Jamal @ 2015-01-23 9:36 UTC (permalink / raw)
To: varkabhadram, alex.aring, linux-wpan, netdev, linux-kernel; +Cc: Mohammad Jamal
This patch solves the coding style issue warning
by replacing the shifting operations by BIT macro
Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com>
---
drivers/net/ieee802154/cc2520.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
index dd129be..b9b2a49 100644
--- a/drivers/net/ieee802154/cc2520.c
+++ b/drivers/net/ieee802154/cc2520.c
@@ -45,9 +45,9 @@
#define CC2520_FREG_MASK 0x3F
/* status byte values */
-#define CC2520_STATUS_XOSC32M_STABLE (1 << 7)
-#define CC2520_STATUS_RSSI_VALID (1 << 6)
-#define CC2520_STATUS_TX_UNDERFLOW (1 << 3)
+#define CC2520_STATUS_XOSC32M_STABLE BIT(7)
+#define CC2520_STATUS_RSSI_VALID BIT(6)
+#define CC2520_STATUS_TX_UNDERFLOW BIT(3)
/* IEEE-802.15.4 defined constants (2.4 GHz logical channels) */
#define CC2520_MINCHANNEL 11
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ieee802154: cc2520: fix coding style issue
2015-01-23 9:36 [PATCH] net: ieee802154: cc2520: fix coding style issue Mohammad Jamal
@ 2015-01-23 9:46 ` Varka Bhadram
2015-01-23 9:48 ` Jamal Mohammad
0 siblings, 1 reply; 3+ messages in thread
From: Varka Bhadram @ 2015-01-23 9:46 UTC (permalink / raw)
To: Mohammad Jamal
Cc: Alexander Aring, linux-wpan - ML, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Hi Mohammad Jamal,
On Fri, Jan 23, 2015 at 3:06 PM, Mohammad Jamal
<md.jamalmohiuddin@gmail.com> wrote:
> This patch solves the coding style issue warning
> by replacing the shifting operations by BIT macro
>
> Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com>
> ---
> drivers/net/ieee802154/cc2520.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
> index dd129be..b9b2a49 100644
> --- a/drivers/net/ieee802154/cc2520.c
> +++ b/drivers/net/ieee802154/cc2520.c
> @@ -45,9 +45,9 @@
> #define CC2520_FREG_MASK 0x3F
>
> /* status byte values */
> -#define CC2520_STATUS_XOSC32M_STABLE (1 << 7)
> -#define CC2520_STATUS_RSSI_VALID (1 << 6)
> -#define CC2520_STATUS_TX_UNDERFLOW (1 << 3)
> +#define CC2520_STATUS_XOSC32M_STABLE BIT(7)
> +#define CC2520_STATUS_RSSI_VALID BIT(6)
> +#define CC2520_STATUS_TX_UNDERFLOW BIT(3)
>
> /* IEEE-802.15.4 defined constants (2.4 GHz logical channels) */
> #define CC2520_MINCHANNEL 11
> --
> 1.7.9.5
>
Please work on bluetooth-next[1] tree and also include
'bluetooth-next' tag for the patch.
[1]: http://git.kernel.org/cgit/linux/kernel/git/bluetooth/bluetooth-next.git/
--
Thanks and Regards,
Varka Bhadram.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ieee802154: cc2520: fix coding style issue
2015-01-23 9:46 ` Varka Bhadram
@ 2015-01-23 9:48 ` Jamal Mohammad
0 siblings, 0 replies; 3+ messages in thread
From: Jamal Mohammad @ 2015-01-23 9:48 UTC (permalink / raw)
To: Varka Bhadram
Cc: Alexander Aring, linux-wpan - ML, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
On Fri, Jan 23, 2015 at 3:16 PM, Varka Bhadram <varkabhadram@gmail.com> wrote:
> Hi Mohammad Jamal,
>
> On Fri, Jan 23, 2015 at 3:06 PM, Mohammad Jamal
> <md.jamalmohiuddin@gmail.com> wrote:
>> This patch solves the coding style issue warning
>> by replacing the shifting operations by BIT macro
>>
>> Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com>
>> ---
>> drivers/net/ieee802154/cc2520.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
>> index dd129be..b9b2a49 100644
>> --- a/drivers/net/ieee802154/cc2520.c
>> +++ b/drivers/net/ieee802154/cc2520.c
>> @@ -45,9 +45,9 @@
>> #define CC2520_FREG_MASK 0x3F
>>
>> /* status byte values */
>> -#define CC2520_STATUS_XOSC32M_STABLE (1 << 7)
>> -#define CC2520_STATUS_RSSI_VALID (1 << 6)
>> -#define CC2520_STATUS_TX_UNDERFLOW (1 << 3)
>> +#define CC2520_STATUS_XOSC32M_STABLE BIT(7)
>> +#define CC2520_STATUS_RSSI_VALID BIT(6)
>> +#define CC2520_STATUS_TX_UNDERFLOW BIT(3)
>>
>> /* IEEE-802.15.4 defined constants (2.4 GHz logical channels) */
>> #define CC2520_MINCHANNEL 11
>> --
>> 1.7.9.5
>>
>
> Please work on bluetooth-next[1] tree and also include
> 'bluetooth-next' tag for the patch.
>
> [1]: http://git.kernel.org/cgit/linux/kernel/git/bluetooth/bluetooth-next.git/
>
> --
> Thanks and Regards,
> Varka Bhadram.
OK , i will send u the patch once i clone the bluetooth-next tree.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-23 9:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-23 9:36 [PATCH] net: ieee802154: cc2520: fix coding style issue Mohammad Jamal
2015-01-23 9:46 ` Varka Bhadram
2015-01-23 9:48 ` Jamal Mohammad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox