From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicholas Mc Guire Subject: [PATCH] hyperv: else branch not necessary Date: Sun, 25 Jan 2015 09:46:50 +0100 Message-ID: <1422175610-1924-1-git-send-email-der.herr@hofr.at> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: devel@linuxdriverproject.org, Haiyang Zhang , Nicholas Mc Guire , linux-kernel@vger.kernel.org, netdev@vger.kernel.org To: "K. Y. Srinivasan" Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org As the if completes with a unconditional goto the else branch is not needed here. Signed-off-by: Nicholas Mc Guire --- All paths of execution that did not exit through the if branch will go through the else branch so no need for an explicit else here Patch was compile tested only for x86_64_defconfig + CONFIG_X86_VSMP=y CONFIG_HYPERV=m, CONFIG_HYPERV_NET=m Patch is against 3.19.0-rc5 -next-20150123 drivers/net/hyperv/rndis_filter.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c index 7bd8387..efb84a9 100644 --- a/drivers/net/hyperv/rndis_filter.c +++ b/drivers/net/hyperv/rndis_filter.c @@ -833,10 +833,10 @@ int rndis_filter_set_packet_filter(struct rndis_device *dev, u32 new_filter) * send completion for it. */ goto exit; - } else { - set_complete = &request->response_msg.msg.set_complete; - status = set_complete->status; - } + } + + set_complete = &request->response_msg.msg.set_complete; + status = set_complete->status; cleanup: if (request) -- 1.7.10.4