From: Vladislav Yasevich <vyasevich@gmail.com>
To: netdev@vger.kernel.org
Cc: edumazet@google.com, mst@redhat.com, ben@decadent.org.uk,
virtualization@lists.linux-foundation.org
Subject: [PATCH 0/3] Restore UFO support to virtio_net devices
Date: Mon, 26 Jan 2015 09:37:03 -0500 [thread overview]
Message-ID: <1422283026-27832-1-git-send-email-vyasevic@redhat.com> (raw)
commit 3d0ad09412ffe00c9afa201d01effdb6023d09b4
Author: Ben Hutchings <ben@decadent.org.uk>
Date: Thu Oct 30 18:27:12 2014 +0000
drivers/net: Disable UFO through virtio
Turned off UFO support to virtio-net based devices due to issues
with IPv6 fragment id generation for UFO packets. The issue
was that IPv6 UFO/GSO implementation expects the fragment id
to be supplied in skb_shinfo(). However, for packets generated
by the VMs, the fragment id is not supplied which causes all
IPv6 fragments to have the id of 0.
The problem is that turning off UFO support on tap/macvtap
as well as virtio devices caused issues with migrations.
Migrations would fail when moving a vm from a kernel supporting
expecting UFO to work to the newer kernels that disabled UFO.
This series provides a partial solution to address the migration
issue. The series reserves a bit in the skb and sets the bit
with the ipv6 fragment id has been generated for the packet.
UFO/GSO code then checks the bit to see if the fragment id
is already present or if a new fragment id needs to be generated.
This solution allows host-originated UFO packets to keep a
better randomized fragment id, as well as generating a randomized
id for VM generated traffic (solving the fragment id 0 issue).
Vladislav Yasevich (3):
ipv6: Select fragment id during UFO/GSO segmentation if not set.
Revert "drivers/net, ipv6: Select IPv6 fragment idents for virtio UFO
packets"
Revert "drivers/net: Disable UFO through virtio"
drivers/net/macvtap.c | 16 ++++++++--------
drivers/net/tun.c | 25 +++++++++----------------
drivers/net/virtio_net.c | 24 ++++++++++--------------
include/linux/skbuff.h | 3 ++-
include/net/ipv6.h | 2 ++
net/ipv6/ip6_output.c | 4 ++--
net/ipv6/output_core.c | 9 ++++++++-
net/ipv6/udp_offload.c | 10 +++++++++-
8 files changed, 50 insertions(+), 43 deletions(-)
--
1.9.3
next reply other threads:[~2015-01-26 14:37 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 14:37 Vladislav Yasevich [this message]
2015-01-26 14:37 ` [PATCH 1/3] ipv6: Select fragment id during UFO/GSO segmentation if not set Vladislav Yasevich
2015-01-27 2:47 ` Ben Hutchings
2015-01-27 8:27 ` David Miller
2015-01-27 8:42 ` Michael S. Tsirkin
2015-01-27 13:47 ` Hannes Frederic Sowa
2015-01-27 14:26 ` Vlad Yasevich
2015-01-27 14:38 ` Eric Dumazet
2015-01-27 16:02 ` Hannes Frederic Sowa
2015-01-27 16:08 ` Michael S. Tsirkin
2015-01-28 8:25 ` Hannes Frederic Sowa
2015-01-28 9:46 ` Michael S. Tsirkin
2015-01-28 10:34 ` Hannes Frederic Sowa
2015-01-28 10:39 ` Hannes Frederic Sowa
2015-01-28 13:43 ` Michael S. Tsirkin
2015-01-28 14:17 ` Hannes Frederic Sowa
2015-01-28 14:16 ` Vlad Yasevich
2015-01-28 14:45 ` Hannes Frederic Sowa
2015-01-28 15:27 ` Vlad Yasevich
2015-01-28 15:49 ` Michael S. Tsirkin
2015-01-28 16:00 ` Michael S. Tsirkin
2015-01-28 16:15 ` Hannes Frederic Sowa
2015-01-28 16:48 ` Michael S. Tsirkin
2015-01-28 17:34 ` Hannes Frederic Sowa
2015-01-28 17:24 ` Ben Hutchings
2015-01-27 16:25 ` Vlad Yasevich
2015-01-26 14:37 ` [PATCH 2/3] Revert "drivers/net, ipv6: Select IPv6 fragment idents for virtio UFO packets" Vladislav Yasevich
2015-01-26 14:37 ` [PATCH 3/3] Revert "drivers/net: Disable UFO through virtio" Vladislav Yasevich
2015-01-27 2:51 ` Ben Hutchings
2015-01-26 15:28 ` [PATCH 0/3] Restore UFO support to virtio_net devices Michael S. Tsirkin
2015-01-26 15:32 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422283026-27832-1-git-send-email-vyasevic@redhat.com \
--to=vyasevich@gmail.com \
--cc=ben@decadent.org.uk \
--cc=edumazet@google.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).